Skip to content

Commit c0de9a9

Browse files
authored
fix(chart): resolve Dex OIDC issuer URL mismatch in development mode (#2838)
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
1 parent 983eab0 commit c0de9a9

4 files changed

Lines changed: 5 additions & 3 deletions

File tree

‎CLAUDE.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,3 +271,4 @@ Code reviews are required for all submissions via GitHub pull requests.
271271
- when creating a commit or PR message, NEVER add co-authored by or generated by Claude code
272272
- any call to authorization Enforce done from the biz or svc layer must be done using biz.AuthzUseCase
273273
- if you modify a schema, remember to run `make migration_sync`
274+
- after changing Helm chart source code (`deployment/chainloop/`), bump the **patch** version (not minor, not major) in the chart's `Chart.yaml`

‎deployment/chainloop/Chart.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ description: Chainloop is an open source software supply chain control plane, a
77

88
type: application
99
# Bump the patch (not minor, not major) version on each change in the Chart Source code
10-
version: 1.342.0
10+
version: 1.342.1
1111
# Do not update appVersion, this is handled automatically by the release process
1212
appVersion: v1.81.2
1313

‎deployment/chainloop/charts/dex/templates/_helpers.tpl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ Figure out the external URL for Dex service
4949
{{- else if (and (eq $service.type "NodePort") $service.nodePorts (not (empty $service.nodePorts.http))) }}
5050
{{- printf "http://localhost:%s" $service.nodePorts.http }}
5151
{{- else -}}
52-
{{- printf "http://%s-dex:%d/dex" ( include "chainloop.dex.fullname" . ) ( int $service.ports.http ) }}
52+
{{- printf "http://%s:%d/dex" ( include "chainloop.dex.fullname" . ) ( int $service.ports.http ) }}
5353
{{- end -}}
5454
{{- end -}}
5555

‎deployment/chainloop/templates/_helpers.tpl‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,8 @@ OIDC settings, will fallback to development settings if needed
183183
{{- define "controlplane.oidc_settings" -}}
184184
{{- if .Values.development }}
185185
{{- with .Values.controlplane.auth }}
186-
{{- $dexContext := dict "Values" $.Values.dex "Chart" $.Chart "Release" $.Release "Capabilities" $.Capabilities "Template" $.Template }}
186+
{{- $dexChart := dict "Name" "dex" }}
187+
{{- $dexContext := dict "Values" $.Values.dex "Chart" $dexChart "Release" $.Release "Capabilities" $.Capabilities "Template" $.Template }}
187188
domain: "{{ coalesce .oidc.url (include "chainloop.dex.external_url" $dexContext ) }}"
188189
client_id: "{{ coalesce .oidc.clientID "chainloop-dev" }}"
189190
client_secret: "{{ coalesce .oidc.clientSecret "ZXhhbXBsZS1hcHAtc2VjcmV0" }}"

0 commit comments

Comments
 (0)