lint

Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>

Author: Piskoo

pkg/attestation/crafter/api/attestation/v1/crafting_state.go

@@ -327,6 +327,7 @@ func (state *CraftingState) GetAnnotations() []*v1.Annotation {
 func (state *CraftingState) GetPolicyGroups() []*v1.PolicyGroupAttachment {
 	switch schema := state.GetSchema().(type) {
 	case *CraftingState_InputSchema:
+		//nolint:staticcheck
 		return schema.InputSchema.GetPolicyGroups()
 	case *CraftingState_SchemaV2:
 		return schema.SchemaV2.GetSpec().GetPolicyGroups()
@@ -339,6 +340,7 @@ func (state *CraftingState) GetPolicyGroups() []*v1.PolicyGroupAttachment {
 func (state *CraftingState) GetPolicies() *v1.Policies {
 	switch schema := state.GetSchema().(type) {
 	case *CraftingState_InputSchema:
+		//nolint:staticcheck
 		return schema.InputSchema.GetPolicies()
 	case *CraftingState_SchemaV2:
 		return schema.SchemaV2.GetSpec().GetPolicies()

pkg/attestation/crafter/api/attestation/v1/crafting_state_validations_test.go

@@ -33,6 +33,7 @@ func TestCraftingStateGetEnvAllowList(t *testing.T) {
 			name: "V1 schema with env vars",
 			state: &CraftingState{
 				Schema: &CraftingState_InputSchema{
+					//nolint:staticcheck
 					InputSchema: &workflowcontract.CraftingSchema{
 						EnvAllowList: []string{"ENV1", "ENV2", "BUILD_NUMBER"},
 					},
@@ -57,6 +58,7 @@ func TestCraftingStateGetEnvAllowList(t *testing.T) {
 			name: "V1 schema with no env vars",
 			state: &CraftingState{
 				Schema: &CraftingState_InputSchema{
+					//nolint:staticcheck
 					InputSchema: &workflowcontract.CraftingSchema{
 						EnvAllowList: []string{},
 					},
@@ -93,6 +95,7 @@ func TestCraftingStateGetEnvAllowList(t *testing.T) {
 }
 
 func TestCraftingStateGetMaterials(t *testing.T) {
+	//nolint:staticcheck
 	v1Materials := []*workflowcontract.CraftingSchema_Material{
 		{
 			Type: workflowcontract.CraftingSchema_Material_ARTIFACT,
@@ -104,6 +107,7 @@ func TestCraftingStateGetMaterials(t *testing.T) {
 		},
 	}
 
+	//nolint:staticcheck
 	v2Materials := []*workflowcontract.CraftingSchema_Material{
 		{
 			Type:     workflowcontract.CraftingSchema_Material_SBOM_CYCLONEDX_JSON,
@@ -113,14 +117,16 @@ func TestCraftingStateGetMaterials(t *testing.T) {
 	}
 
 	testCases := []struct {
-		name              string
-		state             *CraftingState
+		name  string
+		state *CraftingState
+		//nolint:staticcheck
 		expectedMaterials []*workflowcontract.CraftingSchema_Material
 	}{
 		{
 			name: "V1 schema with materials",
 			state: &CraftingState{
 				Schema: &CraftingState_InputSchema{
+					//nolint:staticcheck
 					InputSchema: &workflowcontract.CraftingSchema{
 						Materials: v1Materials,
 					},

pkg/attestation/crafter/crafter_test.go

@@ -138,6 +138,7 @@ func (s *crafterSuite) TestInit() {
 			var err error
 
 			var contractV2 *schemaapi.CraftingSchemaV2
+			//nolint:staticcheck
 			var contract *schemaapi.CraftingSchema
 
 			if isV2Contract {
@@ -169,6 +170,7 @@ func (s *crafterSuite) TestInit() {
 
 				// Create a logger for testing
 				testLogger := zerolog.New(zerolog.Nop()).Level(zerolog.Disabled)
+				//nolint:staticcheck
 				runner := crafter.NewRunner(contract.GetRunner().GetType(), "", &testLogger)
 
 				c, err = newInitializedCrafter(s.T(), tc.contractPath, tc.workflowMetadata, tc.dryRun, tc.workingDir, runner)

pkg/policies/policies_test.go

@@ -225,6 +225,7 @@ func (s *testSuite) TestVerifyAttestations() {
 
 	for _, tc := range cases {
 		s.Run(tc.name, func() {
+			//nolint:staticcheck
 			verifier := NewPolicyVerifier(tc.schema.Policies, nil, &s.logger)
 			statement := loadStatement(tc.statement, &s.Suite)
 
@@ -389,6 +390,7 @@ func (s *testSuite) TestArgumentsInViolations() {
 	}
 
 	s.Run("arguments in violations", func() {
+		//nolint:staticcheck
 		verifier := NewPolicyVerifier(schema.Policies, nil, &s.logger)
 		statement := loadStatement("testdata/statement.json", &s.Suite)
 
@@ -509,6 +511,7 @@ func (s *testSuite) TestMaterialSelectionCriteria() {
 					Materials: tc.policies,
 				},
 			}
+			//nolint:staticcheck
 			pv := NewPolicyVerifier(schema.Policies, nil, &s.logger)
 			atts, err := pv.requiredPoliciesForMaterial(context.TODO(), tc.material)
 			s.Require().NoError(err)
@@ -545,6 +548,7 @@ func (s *testSuite) TestValidInlineMaterial() {
 		InlineCas:    true,
 	}
 
+	//nolint:staticcheck
 	verifier := NewPolicyVerifier(schema.Policies, nil, &s.logger)
 
 	res, err := verifier.VerifyMaterial(context.TODO(), material, "")

pkg/policies/policy_groups_test.go

@@ -163,6 +163,7 @@ func (s *groupsTestSuite) TestRequiredPoliciesForMaterial() {
 				},
 			}
 
+			//nolint:staticcheck
 			v := NewPolicyGroupVerifier(schema.PolicyGroups, nil, nil, &s.logger)
 			group, _, err := new(FileGroupLoader).Load(context.TODO(), &v1.PolicyGroupAttachment{
 				Ref: tc.schemaRef,
@@ -248,6 +249,7 @@ func (s *groupsTestSuite) TestVerifyStatement() {
 	}
 	for _, tc := range cases {
 		s.Run(tc.name, func() {
+			//nolint:staticcheck
 			v := NewPolicyGroupVerifier(tc.schema.PolicyGroups, nil, nil, &s.logger)
 			statement := loadStatement(tc.statement, &s.Suite)
 			res, err := v.VerifyStatement(context.TODO(), statement)
@@ -325,6 +327,7 @@ func (s *groupsTestSuite) TestVerifyMaterialMultiKind() {
 				material.MaterialType = v1.CraftingSchema_Material_OPENVEX
 			}
 
+			//nolint:staticcheck
 			verifier := NewPolicyGroupVerifier(schema.PolicyGroups, nil, nil, &s.logger)
 			res, err := verifier.VerifyMaterial(context.TODO(), material, "")
 
@@ -412,6 +415,7 @@ func (s *groupsTestSuite) TestGroupInputs() {
 			InlineCas:    true,
 		}
 		s.Run(tc.name, func() {
+			//nolint:staticcheck
 			v := NewPolicyGroupVerifier(schema.PolicyGroups, nil, nil, &s.logger)
 			evs, err := v.VerifyMaterial(context.TODO(), material, "")
 			if tc.wantErr {