Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Mapping Issue: Manuscript Deployment Defaults to localhost:0 #60

Open
3 tasks done
anishkandel opened this issue Nov 23, 2024 · 2 comments · Fixed by #62
Open
3 tasks done

Port Mapping Issue: Manuscript Deployment Defaults to localhost:0 #60

anishkandel opened this issue Nov 23, 2024 · 2 comments · Fixed by #62
Labels
bug Something isn't working

Comments

@anishkandel
Copy link

Self Checks

Environment

OS: Ubuntu 20.04 / 22.04
Manuscript CLI Version: Latest (as of date)
Docker Version: e.g., Docker 20.10.21
Compose Version: e.g., Docker Compose v2.20.2

Steps to reproduce

  1. Install Manuscript CLI using the command
    curl -fsSL https://github.com/chainbase-labs/manuscript-core/raw/main/install.sh | bash

  2. Deploy a manuscript using the command:

manuscript-cli deploy /path/to/manuscript.yaml --env=local

  1. Observe the deployment output:
    You can now access your manuscript at http://localhost:0.

  2. Inspect the docker-compose.yaml file to find the port mapping as 0:8080. (All other ports to 0)

✔️ Expected Behavior

The manuscript should be accessible at a valid port, e.g., http://localhost:8080. The docker-compose.yaml file should explicitly bind ports like this:

ports:
  - "8080:8080"

❌ Actual Behavior

When deploying the Manuscript CLI using the provided installation script and Docker Compose, the output indicates:
You can now access your manuscript at http://localhost:0.

The port is incorrectly set to 0, making the service inaccessible. This appears to be a port mapping issue in the generated docker-compose.yaml file. The file includes a mapping like 0:8080, which assigns a random port instead of explicitly binding to a standard port (e.g., 8080:8080).

Actual Behavior:
The deployment defaults to http://localhost:0, and the port binding in the docker-compose.yaml file is incorrect (0:8080).

@anishkandel anishkandel added the bug Something isn't working label Nov 23, 2024
@KagemniKarimu
Copy link
Contributor

❤️ Thank you @anishkandel for reporting this bug 🐛 !

@Liquidwe

I can confirm I had this same issue during our Discord Community Code session on 11/20/2024.

💻 Environment Details

    Linux: fedora-workstation 6.11.8-300.fc41.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Nov 14 20:37:39 UTC 2024 x86_64 GNU/Linux
    Docker: Docker version 27.3.1, build ce12230
    Manuscript-core: Latest (as of 11/20/2024)
    Docker Desktop: 4.36.0

@KagemniKarimu
Copy link
Contributor

This port assignment issue still happens when selecting Print as data output, as shown below:
image

Plausibly because the initialization takes a different path with and without postgres. It should be a simple fix.

@KagemniKarimu KagemniKarimu reopened this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants