Skip to content

Commit a8edd02

Browse files
authored
Support Ruby 3.4 (#208)
1 parent 571757c commit a8edd02

File tree

4 files changed

+32
-2
lines changed

4 files changed

+32
-2
lines changed

.github/workflows/test.yaml

+25
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ jobs:
2626
- "3.1"
2727
- "3.2"
2828
- "3.3"
29+
- "3.4"
2930
- truffleruby-head
3031
gemfile:
3132
- gemfiles/rails_3_0.gemfile
@@ -235,6 +236,30 @@ jobs:
235236
gemfile: gemfiles/rails_5_1.gemfile
236237
- ruby: "3.3"
237238
gemfile: gemfiles/rails_5_2.gemfile
239+
- ruby: "3.4"
240+
gemfile: gemfiles/rails_3_0.gemfile
241+
- ruby: "3.4"
242+
gemfile: gemfiles/rails_3_1.gemfile
243+
- ruby: "3.4"
244+
gemfile: gemfiles/rails_3_2.gemfile
245+
- ruby: "3.4"
246+
gemfile: gemfiles/rails_4_0.gemfile
247+
- ruby: "3.4"
248+
gemfile: gemfiles/rails_4_1.gemfile
249+
- ruby: "3.4"
250+
gemfile: gemfiles/rails_4_2.gemfile
251+
- ruby: "3.4"
252+
gemfile: gemfiles/rails_5_0.gemfile
253+
- ruby: "3.4"
254+
gemfile: gemfiles/rails_5_1.gemfile
255+
- ruby: "3.4"
256+
gemfile: gemfiles/rails_5_2.gemfile
257+
- ruby: "3.4"
258+
gemfile: gemfiles/rails_6_0.gemfile
259+
- ruby: "3.4"
260+
gemfile: gemfiles/rails_6_1.gemfile
261+
- ruby: "3.4"
262+
gemfile: gemfiles/rails_7_0.gemfile
238263
- ruby: truffleruby-head
239264
gemfile: gemfiles/rails_3_0.gemfile
240265
- ruby: truffleruby-head

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# ActiveAttr (Unreleased)
2+
3+
* ActiveAttr now supports Ruby 3.4
4+
15
# ActiveAttr 0.17.1 (November 12, 2024)
26

37
* ActiveAttr now supports Rails 8.0

active_attr.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Gem::Specification.new do |gem|
2929
gem.add_development_dependency "bundler"
3030
gem.add_development_dependency "factory_bot", "< 7.0"
3131
gem.add_development_dependency "minitest"
32-
gem.add_development_dependency "rake", ">= 0.9.0", "< 13.1"
32+
gem.add_development_dependency "rake", ">= 0.9.0", "< 13.3"
3333
gem.add_development_dependency "rspec", "~> 3.0"
3434
gem.add_development_dependency "tzinfo"
3535
end

spec/functional/active_attr/model_spec.rb

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# frozen_string_literal: true
12
require "spec_helper"
23
require "active_attr/model"
34
require "active_model/mass_assignment_security"
@@ -141,7 +142,7 @@ def self.name
141142
private
142143

143144
def remove_whitespaces
144-
name.strip!
145+
self.name = name.strip
145146
end
146147

147148
def set_status

0 commit comments

Comments
 (0)