Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Move all source Dart files to *_impl.dart to avoid naming collision #2383

Merged
merged 2 commits into from
Feb 25, 2025
Merged

♻️ Move all source Dart files to *_impl.dart to avoid naming collision #2383

merged 2 commits into from
Feb 25, 2025

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Feb 21, 2025 •
edited
Loading

Workaround with dart-lang/sdk#56498

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

v1 also needs to be updated.

@AlexV525 AlexV525 linked an issue Feb 21, 2025 that may be closed by this pull request
TypeError: Cannot read properties with BrowserHttpClientAdapter() when debugging on Web #2282
Closed
@github-actions GitHub Actions
Copy link
Contributor

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
Overall Coverage 🟢 84.79% 🟢 84.79% ⚪ 0%

Minimum allowed coverage is 0%, this run produced 84.79%

@AlexV525 AlexV525 marked this pull request as ready for review February 25, 2025 05:57
@AlexV525 AlexV525 requested a review from a team as a code owner February 25, 2025 05:57
@AlexV525 AlexV525 merged commit 23d218c into main Feb 25, 2025
3 checks passed
@AlexV525 AlexV525 deleted the fix/naming-collision branch February 25, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhnroyal kuhnroyal kuhnroyal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties with BrowserHttpClientAdapter() when debugging on Web
2 participants
@AlexV525 @kuhnroyal