Skip to content
This repository has been archived by the owner on Jun 24, 2020. It is now read-only.

Loan Comparison Downpayment - Deleted numbers stayed #470

Open
amymok opened this issue Jun 10, 2015 · 4 comments
Open

Loan Comparison Downpayment - Deleted numbers stayed #470

amymok opened this issue Jun 10, 2015 · 4 comments

Comments

@amymok
Copy link
Contributor

amymok commented Jun 10, 2015

I was updating Downpayment (you can try this on either % or the actual amount). If you enter whatever, then hold the "delete" key until everything is deleted. And then you pause (lift your finger away from the "delete" key), you will see whatever you deleted comes back.

So if you enter a number right away, it will concatenate the newly entered number to the deleted item.

Is this expected behavior we want?

@stephanieosan @cfarm @virginiacc

@stephanieosan
Copy link
Member

No, that's weird! I wonder what we do want to happen, though. Ideas?

@cfarm
Copy link
Contributor

cfarm commented Jun 11, 2015

We talked about this during pairing yesterday and came up with some ideas for the down payment inputs:

  • Instead of whatever you entered reappearing after hitting delete, the field should stay blank or change to 0
  • Instead of debouncing the change event so that every few seconds after typing the field data updates, we could use the blur event and wait until the user moves on to the next field. This would mean the downpayment percent and dollar amounts would only update each other after the user focuses on another part of the page, and would also prevent error messaging from appearing while typing
  • Instead of placeholder values for the down payment scenario, it should just default to the default value - placeholder can appear as "25,000" if you start to delete the text.

@virginiacc
Copy link
Contributor

This should be fixed with #474 -- there was a bug with empty downpayment values. The field now will be blank when the input's content is deleted. I kept the current change event behaviour, but removed the placeholders as per @cfarm's comment above.

@mthibos
Copy link
Contributor

mthibos commented Jun 15, 2015

@virginiacc Come to think of it, I think we had a similar bug when we were launching Explore Rates, and I think we fixed it the same way. Good choice!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants