Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding river and lake to the area type table ? #65

Open
gnikulin opened this issue Apr 15, 2024 · 10 comments
Open

adding river and lake to the area type table ? #65

gnikulin opened this issue Apr 15, 2024 · 10 comments
Assignees
Labels
vocabulary Standard names and other CF controlled vocabulary

Comments

@gnikulin
Copy link

There was a very long issue with many discussions #25 about new standard names for lake and river variables. My understanding is that there was a common agreement to add river and lake to the area type table. However, I don't see lake and river in the area type table. There are fresh_free_water that can be used but don't separate between lakes and rivers and also one area type - lake_ice_or_sea_ice where at least lake appears. Perhaps, it's easier to open a new issue focusing only on the area type for lakes and rivers.

@gnikulin gnikulin added the question Further information is requested label Apr 15, 2024
@JonathanGregory
Copy link
Contributor

JonathanGregory commented Apr 15, 2024

Dear Grisha @gnikulin

I agree, that point wasn't taken up as a definite proposal. I believe you are proposing now that we should add lake and river area-types - is that correct? On that assumption, I'll change the label from question to vocabulary. Several people supported adding these new area types in principle, and raised significant points to be addressed.

Beate @GeyerB proposed definitions:

An area type of "lake" means a body of (usually fresh) water surrounded by land.
An area type of "river" means a natural stream of water of considerable volume. (see http://glossary.ametsoc.org/wiki/River)

Karl @taylor13 asked:

Can we clarify in our definition what distinguishes a lake from an inland sea? I've seen descriptions that say a sea is at sea level and connected to an ocean while a lake may be above or below sea level and if connected to the ocean is not a "sea". (Under this definition the "Dead Sea" is a lake.)

Best wishes

Jonathan

@JonathanGregory JonathanGregory added vocabulary Standard names and other CF controlled vocabulary and removed question Further information is requested labels Apr 15, 2024
@gnikulin
Copy link
Author

I believe you are proposing now that we should add lake and river area-types - is that correct? On that assumption, I'll change the label from question to vocabulary.

Jonathan, yes, it's exactly what I meant - to add lake and river area-types. Changing the label from question to vocabulary is absolutely fine.

Karl @taylor13 asked:

Can we clarify in our definition what distinguishes a lake from an inland sea? I've seen descriptions that say a sea is at sea level and connected to an ocean while a lake may be above or below sea level and if connected to the ocean is not a "sea". (Under this definition the "Dead Sea" is a lake.)

One of differences between lakes and inland seas may be salinity I think, freshwater lake or salt lake . Wiki says "An inland sea will generally be brackish, with higher salinity than a freshwater lake but usually lower salinity than seawater."

@taylor13
Copy link

In CF I think most folks currently interpret "sea" as a body of water of considerable size at sea level. Perhaps we could use the term "inland_seas_and_lakes" to distinguish other surface waters from rivers and streams.

@gnikulin
Copy link
Author

Just chatted with a lake modeller and salinity is not the best criteria to distinguish between a lake and an inland sea as there are many salty lakes that are not inland seas. It was also mentioned that still there is no clear definition how to distinguish between lakes and inland seas. Perhaps, "inland_seas_and_lakes" as Karl suggested may be a good option.

@gnikulin
Copy link
Author

Can we preliminary summarise that:

  • Lake and inland sea: an area type of inland_sea_and_lake means a body of water surrounded by land.

lake_and_inland_sea sounds a bit better for me ?

@gnikulin
Copy link
Author

@JonathanGregory may we expect any actions here ?

@larsbarring larsbarring added the standard name (added by template) Requests and discussions for standard names and other controlled vocabulary label May 29, 2024
Copy link

Thank you for your proposal. These terms will be added to the cfeditor (http://cfeditor.ceda.ac.uk/proposals/1) shortly. Your proposal will then be reviewed and commented on by the community and Standard Names moderator.

@larsbarring
Copy link

I have just added the label "standard name" as the issue template specifically mentions changes to the area type table.

@JonathanGregory JonathanGregory added the add to cfeditor (added by template) Moderators are requested to add this proposal to the CF editor label May 29, 2024
@JonathanGregory
Copy link
Contributor

Please could the standard name moderators consider this proposal for the area type table? @efisher008 @japamment @feggleton

@efisher008 efisher008 removed the standard name (added by template) Requests and discussions for standard names and other controlled vocabulary label Jul 24, 2024
@efisher008 efisher008 removed the add to cfeditor (added by template) Moderators are requested to add this proposal to the CF editor label Jul 29, 2024
@efisher008 efisher008 transferred this issue from cf-convention/discuss Jul 29, 2024
@japamment
Copy link
Member

Many thanks for proposing these new area types @gnikulin and apologies for the delay in responding to this issue.

It seems there is support for adding these two new entries to the area type table:
lake_and_inland_sea
Description: An area type of lake_and_inland_sea means a body of water surrounded by land.

I think this one is agreed and as there have been no further comments since May 2024 it is accepted for publication in the area type table. It will be included in the next update on 20th-21st January.

A similar proposal has also been made in #222 and I think both issues can be resolved by adding this area type.

river
Description: An area type of river means a natural stream of water of considerable volume, (see http://glossary.ametsoc.org/wiki/River).

The description you have provided is fine, however for standard names for river quantities we use the following text " "River" refers to water in the fluvial system (stream and floodplain)." @gnikulin would you be okay to use this existing description as we will then have consistency between the area type and standard name tables?

Best wishes,
Alison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vocabulary Standard names and other CF controlled vocabulary
Projects
None yet
Development

No branches or pull requests

7 participants