Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocean_volume vs. sea_water_volume #61

Closed
taylor13 opened this issue Sep 26, 2022 · 8 comments
Closed

ocean_volume vs. sea_water_volume #61

taylor13 opened this issue Sep 26, 2022 · 8 comments
Labels
accepted Agreed for inclusion in the next release of the standard name table or other controlled vocabulary question Further information is requested standard name (added by template) Requests and discussions for standard names and other controlled vocabulary

Comments

@taylor13
Copy link

taylor13 commented Sep 26, 2022

What is the difference between "ocean_volume" and "sea_water_volume". In the standard names listing, the note for sea_water_volume says "The quantity with standard name "sea_water_volume" is the total volume of liquid seawater in the global oceans, including enclosed seas."
There is no information provided regarding "ocean_volume". Should these two names be declared aliases for the same thing?

@taylor13 taylor13 added the question Further information is requested label Sep 26, 2022
@JonathanGregory
Copy link
Contributor

I agree that òcean_volume should be an alias of sea_water_volume and therefore ocean_volume_fraction should be renamed (made an alias) of sea_water_volume_fraction. I think the latter also makes sense because sea water is the name of the medium from which the ocean is composed.

@feggleton feggleton added the standard name (added by template) Requests and discussions for standard names and other controlled vocabulary label Nov 3, 2022
@github-actions
Copy link

This issue has had no activity in the last 30 days. This is a reminder to please comment on standard name requests to assist with agreement and acceptance. Standard name moderators are also reminded to review @feggleton @japamment

@github-actions github-actions bot added the moderator attention (added by GitHub action) Moderators are requested to consider this issue label Mar 25, 2023
@efisher008 efisher008 transferred this issue from cf-convention/discuss Jul 29, 2024
@github-actions github-actions bot removed the moderator attention (added by GitHub action) Moderators are requested to consider this issue label Jul 31, 2024
@efisher008
Copy link
Collaborator

Hi @taylor13 @JonathanGregory,

I agree with the above discussion and have made the following changes in the editor (although they are currently labelled as "under discussion"):

Is this what you intended? Would it also be needed to alter the description of both names to include the definition of the phrase sea_water i.e. add "Sea water refers to liquid seawater in the global oceans, including enclosed seas."? This could then be added to the CF phrasebank. The wording of this can be changed if necessary.

Another question: should I now remove the "old" ocean_volume name from the table? I don't believe this should cause any issues as it is now an alias of sea_water_volume, and the old name doesn't have a description so there is nothing to transfer.

Best wishes,
Ellie

@JonathanGregory
Copy link
Contributor

Dear Ellie

Yes, that's what was meant. It would certainly be an improvement to add the definition of sea_water to the description of these names, thanks. I don't think we ever delete names from the table, do we. That's the reason for having aliases. There may be existing archived datasets which use the standard name ocean_volume, so we have to keep it in the table, as an alias of sea_water_volume, where its definition will go. Have I misunderstood?

Best wishes

Jonathan

@efisher008
Copy link
Collaborator

Dear Jonathan,

Apologies, I think I misunderstood how the name would be transformed when aliased. What I meant is that ocean_volume should no longer have its own entry in the table, rather it should be attached as an alias to the published name sea_water_volume. The way that the CF editor works currently is that a name is automatically aliased when a term change is proposed (accepted) from the previously published version. It is also possible to manually add an alias in the system without proposing a term change, which is what I had done. I thought that there would therefore be a standalone entry remaining for ocean_volume which would need to be dealt with, but it actually seems as though this has been taken care of when the alias was created, so there is no need to remove/'delete' anything (which as you said is not done for the standard name table).

Best wishes,
Ellie

@efisher008
Copy link
Collaborator

Both changes have now been accepted as the issue previously reached a consensus and there have been no new comments to the contrary. Thank you @taylor13 @JonathanGregory for your comments.

@efisher008 efisher008 added the accepted Agreed for inclusion in the next release of the standard name table or other controlled vocabulary label Aug 7, 2024
@JonathanGregory
Copy link
Contributor

Thanks for your help, Ellie, and your explanation of how the editor manages aliases.

@taylor13
Copy link
Author

taylor13 commented Aug 7, 2024

Yes, thank you for cleaning this all up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Agreed for inclusion in the next release of the standard name table or other controlled vocabulary question Further information is requested standard name (added by template) Requests and discussions for standard names and other controlled vocabulary
Projects
None yet
Development

No branches or pull requests

4 participants