Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rights #63

Closed
marqh opened this issue Jan 13, 2016 · 9 comments
Closed

Merge rights #63

marqh opened this issue Jan 13, 2016 · 9 comments
Assignees

Comments

@marqh
Copy link
Member

marqh commented Jan 13, 2016

I think there is a need to agree which users have merge rights to this repository and implement the permissions.

I provided review and merge services on this repository's predecessor, but I am unable to provide this service now, as my permissions do not allow it.

Please may we create a team to manage merging of content onto this repository and agree its membership?

thank you
mark

@rhattersley
Copy link
Member

👍 ... for example, see #62 (comment)

@mattben
Copy link
Contributor

mattben commented Jan 13, 2016

Agreed @marqh

I've updated the teams page (github teams changed a while back). I have created two teams web for the site and conventions for all the other repos.

@rsignell-usgs and @painter1 as I am solely a web dude, can you two please populate these teams with the appropriate people.

For @rhattersley example, that is a PR in a conventions repo and is out side my confort zone to merge. I feel I should only merge and touch the website.

@painter1
Copy link
Contributor

We have 16 people in the Contributors team. It has write access, so all should be able to approve pull requests. @mattben, how should that team differ from your new "conventions" team? Anyone, do you have opinions on who belongs in the "conventions" team? Everyone in Contributors?

@japamment
Copy link
Member

Can someone please explain to me what is happening with the various cf-conventions repositories on github? I have just tried to push something to cf-convention/cf-convention.github.io.git (to correct an error in the standard name table) and received a permission denied message. This worked fine about a month ago. Do I need to be added back in as a Member?

@japamment japamment reopened this Jan 21, 2016
@mattben
Copy link
Contributor

mattben commented Jan 21, 2016

@japamment yes, we are waiting on @rsignell-usgs and @painter1 to assign people to the different development teams. in the mean time you can create a pull request from another branch or your fork and I can merge it. (but only for the website repo)

@japamment
Copy link
Member

OK, thanks, I have created a pull request from japamment/cf-convention.github.io to cf-convention/cf-convention.github.io – would you be able to merge it, please?

From: Matthew Harris [mailto:[email protected]]
Sent: 21 January 2016 14:35
To: cf-convention/cf-conventions
Cc: Pamment, Alison (STFC,RAL,RALSP)
Subject: Re: [cf-conventions] Merge rights (#63)

@japammenthttps://github.com/japamment yes, we are waiting on @rsignell-usgshttps://github.com/rsignell-usgs and @painter1https://github.com/painter1 to assign people to the different development teams. in the mean time you can create a pull request from another branch or your fork and I can merge it. (but only for the website repo)


Reply to this email directly or view it on GitHubhttps://github.com//issues/63#issuecomment-173586368.

@rhattersley
Copy link
Member

we are waiting on @rsignell-usgs and @painter1 to assign people to the different development teams

  1. Please can someone (@mattben? @rsignell-usgs?) give the "conventions" team write access to this repo?
  2. Please can we (@rsignell-usgs? @painter1?) expand the membership of the "conventions" team so we can start merging some pull requests and making progress on 1.7?

With (1) done I'd (reluctantly) get @cf-conventions-bot to merge its own pull-request, #71, as that's just an infrastructure change, but I would not want it to be used to merge content changes.

@dblodgett-usgs
Copy link
Contributor

It seems this issue has been resolved? If not, maybe it should be closed and reopened with a clear purpose?

@dblodgett-usgs
Copy link
Contributor

This issue will be further discussed in and is superseded by #172 and #173.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants