-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge rights #63
Comments
👍 ... for example, see #62 (comment) |
Agreed @marqh I've updated the teams page (github teams changed a while back). I have created two teams @rsignell-usgs and @painter1 as I am solely a web dude, can you two please populate these teams with the appropriate people. For @rhattersley example, that is a PR in a conventions repo and is out side my confort zone to merge. I feel I should only merge and touch the website. |
We have 16 people in the Contributors team. It has write access, so all should be able to approve pull requests. @mattben, how should that team differ from your new "conventions" team? Anyone, do you have opinions on who belongs in the "conventions" team? Everyone in Contributors? |
Can someone please explain to me what is happening with the various cf-conventions repositories on github? I have just tried to push something to cf-convention/cf-convention.github.io.git (to correct an error in the standard name table) and received a permission denied message. This worked fine about a month ago. Do I need to be added back in as a Member? |
@japamment yes, we are waiting on @rsignell-usgs and @painter1 to assign people to the different development teams. in the mean time you can create a pull request from another branch or your fork and I can merge it. (but only for the website repo) |
OK, thanks, I have created a pull request from japamment/cf-convention.github.io to cf-convention/cf-convention.github.io – would you be able to merge it, please? From: Matthew Harris [mailto:[email protected]] @japammenthttps://github.com/japamment yes, we are waiting on @rsignell-usgshttps://github.com/rsignell-usgs and @painter1https://github.com/painter1 to assign people to the different development teams. in the mean time you can create a pull request from another branch or your fork and I can merge it. (but only for the website repo) — |
With (1) done I'd (reluctantly) get @cf-conventions-bot to merge its own pull-request, #71, as that's just an infrastructure change, but I would not want it to be used to merge content changes. |
It seems this issue has been resolved? If not, maybe it should be closed and reopened with a clear purpose? |
I think there is a need to agree which users have merge rights to this repository and implement the permissions.
I provided review and merge services on this repository's predecessor, but I am unable to provide this service now, as my permissions do not allow it.
Please may we create a team to manage merging of content onto this repository and agree its membership?
thank you
mark
The text was updated successfully, but these errors were encountered: