Skip to content

Commit 28dc0d1

Browse files
authored
Merge pull request meshery#10487 from MUzairS15/MUzairS15/yaml/split-fix
[mesheryctl] Update model generator.
2 parents 047aeb9 + 65b130c commit 28dc0d1

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

mesheryctl/pkg/utils/model.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import (
1414

1515
var (
1616
shouldRegisterMod = "publishToSites"
17-
shouldRegisterToRegsitry = "publishToRegistry"
1817
)
1918

2019
type ModelCSV struct {
@@ -130,7 +129,9 @@ func (mch *ModelCSVHelper) ParseModelsSheet(parseForDocs bool) error {
130129
if parseForDocs {
131130
index = GetIndexForRegisterCol(columns, shouldRegisterMod)
132131
} else {
133-
index = GetIndexForRegisterCol(columns, shouldRegisterToRegsitry)
132+
// Generation of models should not consider publishedToRegistry column value.
133+
// Generation should happen for all models, while during registration "published" attribute should be respected.
134+
return true
134135
}
135136
if index != -1 && index < len(currentRow) {
136137
shouldRegister := currentRow[index]

0 commit comments

Comments
 (0)