Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csi: correct conditional logic for fuse mount options argument #206

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

iPraveenParihar
Copy link
Contributor

Describe what this PR does

Previously, the function incorrectly checked if len(options) == 0, causing it to return a non-empty argument when no options were provided. This fix updates the condition to len(options) > 0, ensuring the argument is only set when options exist.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Previously, the function incorrectly checked if `len(options) == 0`,
causing it to return a non-empty argument when no options were provided.
This fix updates the condition to `len(options) > 0`, ensuring the argument
is only set when options exist.

Signed-off-by: Praveen M <[email protected]>
@iPraveenParihar
Copy link
Contributor Author

cc @Madhu-1 PTAL

@Madhu-1 Madhu-1 merged commit e58debc into ceph:main Feb 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants