Commit a695c5c
Optimize Multisig submitAndConfirm (#743)
### Description
Reports that it took very long/timed out when approving a transaction
#### Other changes
adds ability to specify if submitting or confirming by passing
`--submit` or `--multisigTx NUMBER`
### Tested.
### How to QA
try to approve something
### Related issues
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the multisig transaction approval process
in the `@celo/contractkit` and `@celo/celocli` packages by introducing
new methods and command flags for better control over transaction
submission and confirmation.
### Detailed summary
- Updated transaction submission logic to search only non-executed
transactions.
- Added `submitTransaction` method in `MultiSigWrapper` for manual
submission.
- Introduced `--submit` and `--multisigTx` flags in `governance:approve`
command for enhanced control.
- Added checks in tests to ensure proper validation of multisig
transactions.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`
<!-- end pr-codex -->
---------
Co-authored-by: Martín Volpe <volpe@clabs.co>1 parent ec19218 commit a695c5c
File tree
6 files changed
+910
-353
lines changed- .changeset
- packages
- cli/src/commands/governance
- sdk/contractkit/src/wrappers
6 files changed
+910
-353
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
0 commit comments