Skip to content

Commit a695c5c

Browse files
aaronmgdrmartinvol
andauthored
Optimize Multisig submitAndConfirm (#743)
### Description Reports that it took very long/timed out when approving a transaction #### Other changes adds ability to specify if submitting or confirming by passing `--submit` or `--multisigTx NUMBER` ### Tested. ### How to QA try to approve something ### Related issues <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the multisig transaction approval process in the `@celo/contractkit` and `@celo/celocli` packages by introducing new methods and command flags for better control over transaction submission and confirmation. ### Detailed summary - Updated transaction submission logic to search only non-executed transactions. - Added `submitTransaction` method in `MultiSigWrapper` for manual submission. - Introduced `--submit` and `--multisigTx` flags in `governance:approve` command for enhanced control. - Added checks in tests to ensure proper validation of multisig transactions. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> --------- Co-authored-by: Martín Volpe <volpe@clabs.co>
1 parent ec19218 commit a695c5c

File tree

6 files changed

+910
-353
lines changed

6 files changed

+910
-353
lines changed
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
'@celo/celocli': minor
3+
---
4+
5+
Add new flags to `governance:approve` command for better multisig transaction control:
6+
7+
- `--submit`: Force submission of approval transaction to multisig without checking for prior confirmations onchain. Use with caution - this bypasses the check for existing submissions. Example: `celocli governance:approve --proposalID 99 --from 0x... --useMultiSig --submit`
8+
9+
- `--multisigTx`: Specify exact multisig transaction ID to confirm, rather than searching onchain. Useful when you know the transaction ID from offchain sources. Example: `celocli governance:approve --proposalID 99 --from 0x... --useMultiSig --multisigTx 5`
10+
11+
Both flags depend on `--proposalID` and `--useMultiSig` being provided.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@celo/contractkit': patch
3+
---
4+
5+
Add `submitTransaction` method to `MultiSigWrapper` to submit transactions to multisig without automatic confirmation. This complements the existing `submitOrConfirmTransaction` method by providing more granular control over the submission process.

.changeset/open-donkeys-nail.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@celo/contractkit': patch
3+
'@celo/celocli': patch
4+
---
5+
6+
Updates logic for submiting/confirming transaction with multisig to only search thru non executed transactions

0 commit comments

Comments
 (0)