SimApp uses an older version of ibc-go

[rootulp]

Context

SimApp currently uses an older version of ibc-go here. The commit of solidity-ibc-eureka that this repo uses, uses a more recent version of ibc-go here.

Problem

@fl0rek reported that the attribute names in parsed simapp events don't seem compatible with the relayer in the eureka repo.

Proposal

Explore if bumping the ibc-go version resolves @fl0rek problem. If it does, bump the ibc-go version in SimApp. Note this is non-trivial because it involves bumping the SDK version of SimApp which includes a breaking change to import paths.

[rootulp]

Note: when we bump ibc-go we will likely have to modify the messages sent during make setup. The version of ibc-go we currently use creates channels

celestia-zkevm-ibc-demo/testing/demo/pkg/setup/initialise_groth16_client.go

Lines 131 to 148 in 7725583

	func createChannelOnSimapp(clientCtx client.Context, clientId string) error {
	cosmosMerklePathPrefix := commitmenttypesv2.NewMerklePath([]byte("simd"))
	msg := channeltypesv2.MsgCreateChannel{
	ClientId: clientId,
	MerklePathPrefix: cosmosMerklePathPrefix,
	Signer: relayer,
	}
	response, err := utils.BroadcastMessages(clientCtx, relayer, 200_000, &msg)
	if err != nil {
	return fmt.Errorf("failed to create channel: %v", err)
	}
	if response.Code != 0 {
	return fmt.Errorf("failed to create channel: %v", response.RawLog)
	}
	fmt.Println("Created channel on simapp.")
	return nil
	}

but that should be removed in more recent versions of ibc-go because IBC Eureka is channel-less.

Also this function

celestia-zkevm-ibc-demo/testing/demo/pkg/setup/initialise_sp1tm_client.go

Lines 78 to 123 in 7725583

	func createChannelAndCounterpartyOnReth(addresses utils.ContractAddresses, ethClient *ethclient.Client) error {
	ethChainId := big.NewInt(80087)
	ethPrivateKey := "0x82bfcfadbf1712f6550d8d2c00a39f05b33ec78939d0167be2a737d691f33a6a"
	icsClientContract, err := ics02client.NewContract(ethcommon.HexToAddress(addresses.ICS02Client), ethClient)
	if err != nil {
	return fmt.Errorf("failed to instantiate ICS Core contract: %v", err)
	}
	counterpartyInfo := ics02client.IICS02ClientMsgsCounterpartyInfo{
	ClientId: counterpartyClientId,
	MerklePrefix: [][]byte{[]byte("ibc"), []byte("")},
	}
	tmLightClientAddress := ethcommon.HexToAddress(addresses.ICS07Tendermint)
	key, err := crypto.ToECDSA(ethcommon.FromHex(ethPrivateKey))
	if err != nil {
	return fmt.Errorf("failed to convert private key: %v", err)
	}
	fmt.Printf("Adding client to the ICS Client contract on reth node with counterparty clientId %s...\n", counterpartyInfo.ClientId)
	tx, err := icsClientContract.AddClient(GetTransactOpts(key, ethChainId, ethClient), ibcexported.Tendermint, counterpartyInfo, tmLightClientAddress)
	if err != nil {
	return fmt.Errorf("failed to add channel: %v", err)
	}
	receipt := GetTxReceipt(context.Background(), ethClient, tx.Hash())
	event, err := GetEvmEvent(receipt, icsClientContract.ParseICS02ClientAdded)
	if err != nil {
	return fmt.Errorf("failed to get event: %v", err)
	}
	if event.ClientId != expectedClientId {
	return fmt.Errorf("expected clientId %s, got %s", expectedClientId, event.ClientId)
	}
	if event.CounterpartyInfo.ClientId != counterpartyClientId {
	return fmt.Errorf("expected counterparty clientId %s, got %s", counterpartyClientId, event.CounterpartyInfo.ClientId)
	}
	fmt.Printf("Added client to the ICS client contract on reth node with clientId %s and counterparty clientId %s\n", event.ClientId, event.CounterpartyInfo.ClientId)
	TendermintLightClientID = event.CounterpartyInfo.ClientId
	return nil
	}

does not create a channel even though the function name claims it does.

Based on the spec instead of the channels, we just register counterparties.

cc: @ninabarbakadze

[rootulp]

We should tackle this in stages:

1. First bump to the version of ibc-go that our commit of solidity-ibc-eureka uses: https://github.com/cosmos/solidity-ibc-eureka/blob/b241dc7658dc1540013430851f6e861e2df7cd51/e2e/interchaintestv8/go.mod#L314
2. Later, only if needed bump our version of solidity-ibc-eureka to more recent commit and then bump ibc-go to the version used by that commit.

[rootulp]

We're bumping ibc-go from 3d84b47307b9 to 7dd7d2711c58: cosmos/ibc-go@7dd7d27 but that commit transitively pulls in cosmos-sdk v0.52.x which has been retracted 😢

go: github.com/cosmos/[email protected]: reading github.com/cosmos/cosmos-sdk/go.mod at revision v0.52.0: unknown revision v0.52.0

so we may have to bump to latest solidity-ibc-eureka and ibc-go

[rootulp]

ICS20 v2 was removed in this PR so I think we need to modify to just use ICS20 v1 with IBC Eureka