Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-prove prove build --output-directory provers/celestia-prover/elf fails #157

Open
rootulp opened this issue Feb 13, 2025 · 0 comments · May be fixed by #158
Open

cargo-prove prove build --output-directory provers/celestia-prover/elf fails #157

rootulp opened this issue Feb 13, 2025 · 0 comments · May be fixed by #158
Assignees
Labels
bug Something isn't working demo Needed to complete demo

Comments

@rootulp
Copy link
Collaborator

rootulp commented Feb 13, 2025

Context

On main

~/.sp1/bin/cargo-prove prove build --elf-name mock-membership-elf

Problem

That command doesn't work:

$ ~/.sp1/bin/cargo-prove prove build --elf-name mock-membership-elf
error: the following required arguments were not provided:
  --output-directory <OUTPUT_DIRECTORY>

I get unresolved import errors if I do:

$ cargo-prove prove build --output-directory provers/celestia-prover/elf

cc: @ninabarbakadze

Proposal

  1. Investigate the issue. It seems likely that the SP1 programs are pulling in crates that they aren't allowed to. In other words, they're pulling in crates that can't run inside SP1.
  2. Fix the issue
@rootulp rootulp added the bug Something isn't working label Feb 13, 2025
@ninabarbakadze ninabarbakadze self-assigned this Feb 14, 2025
@rootulp rootulp added the demo Needed to complete demo label Feb 14, 2025
@rootulp rootulp linked a pull request Feb 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working demo Needed to complete demo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants