feat: switch between mock and prod circuits #158
Conversation
provers/celestia-prover/README.md
Outdated
|
|
||
| If you update the circuits please regenerate the `elf` files: | ||
|
|
||
| ```shell | ||
| ~/.sp1/bin/cargo-prove prove build --elf-name mock-membership-elf | ||
| ``` |
There was a problem hiding this comment.
❤️ thanks for removing this
| const ELF: &'static [u8] = include_bytes!("../../elf/mock-update-client-elf"); | ||
| const ELF: &[u8] = include_elf!("mock-membership"); | ||
| } | ||
|
|
||
| impl SP1Program for MembershipProgram { | ||
| const ELF: &'static [u8] = include_bytes!("../../elf/mock-membership-elf"); |
| members = [ | ||
| "../programs/sp1/mock-membership", | ||
| "../programs/sp1/mock-update-client", | ||
| ] |
There was a problem hiding this comment.
[question] what does including these programs as members of the celestia-prover crate do? They're already members of the root level workspace here. I don't quite understand when/why to include them as members of this crate.
There was a problem hiding this comment.
I think if you want to share the packages that are defined in the parent package is one of the reasons. I don't fully understand either. I was trying to debug compiling the mock programs and was trying to see if any of these would help.
| @@ -1,5 +1,5 @@ | |||
| #![doc = include_str!("../../README.md")] | |||
| #![deny(clippy::nursery, clippy::pedantic, warnings, missing_docs)] | |||
|
|
|||
| pub mod programs; | |||
| pub mod programs; | |||
There was a problem hiding this comment.
| pub mod programs; | |
| pub mod programs; |
|
Note to self, if this merges after https://github.com/celestiaorg/celestia-zkevm-ibc-demo/pull/153/files#diff-3e3eeb59d344e85d64268133b460af890852ed1aa94c6e049556a9dc3c2aa60cR74-R83 then we can remove those lines from the README b/c this PR auto rebuilds the ELFs |
ninabarbakadze
force-pushed
the
nina/switch-between-circuits
branch
from
87f5beb to
d59d361
Compare
Closes #138
Closes #157