Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Difficulty Tabs Into Own Component #768

Open
otobot1 opened this issue Apr 26, 2024 · 0 comments
Open

Extract Difficulty Tabs Into Own Component #768

otobot1 opened this issue Apr 26, 2024 · 0 comments
Labels
priority: low type: code quality Improve code readability
Milestone

Comments

@otobot1
Copy link
Member

otobot1 commented Apr 26, 2024

Is your feature request related to a problem? Please describe.
The difficulty tabs are rendered by the main ModsTable component. The ModsTable component is already very cluttered.

Describe the solution you'd like
Extract the difficulty tabs into their own component (in a new file). This will make the ModsTable component at least slightly more clean.

Describe alternatives you've considered
N/A

Additional context
Follow-up to #752 issue 1.

This change may be tricky/impossible. When a fix was attempted as part of an earlier PR, the difficulty tabs started breaking when the page was hot-reloaded by Next.js dev mode. If this can be fixed/worked-around, great. If not, it's a huge deal to leave things the way they are.

@otobot1 otobot1 added type: code quality Improve code readability priority: low labels Apr 26, 2024
@otobot1 otobot1 added this to the v0.4.0 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low type: code quality Improve code readability
Projects
None yet
Development

No branches or pull requests

1 participant