Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulty Header Separated From Info Header #724

Open
campbell-godfrey opened this issue Feb 21, 2024 · 7 comments
Open

Difficulty Header Separated From Info Header #724

campbell-godfrey opened this issue Feb 21, 2024 · 7 comments
Labels
priority: very high status: help wanted This issue is low-priority for maintainers. Any user is welcome to submit a pull request type: bug Something isn't working
Milestone

Comments

@campbell-godfrey
Copy link

The screenshot depicts the headers separated vertically instead of connected. See screenshot below for reference. I believe that this bug is replicable for anyone on Safari.
I am using: MacBook Pro, Sonoma 14.2.1, Safari

Screenshot 2024-02-21 at 5 23 52 PM
@otobot1 otobot1 added the type: bug Something isn't working label Feb 21, 2024
@otobot1 otobot1 changed the title Bug: Difficulty Header Separated From Info Header Difficulty Header Separated From Info Header Feb 21, 2024
@otobot1 otobot1 added this to the v0.1.1 milestone Feb 21, 2024
@otobot1 otobot1 added priority: high status: help wanted This issue is low-priority for maintainers. Any user is welcome to submit a pull request labels Feb 21, 2024
@otobot1
Copy link
Member

otobot1 commented Apr 5, 2024

A friend of mine with a mac did some poking. They weren't able to quite figure out what the issue is exactly, but they think it has to do with the use of position: sticky on the table header and tab container. From our googling, safari seems to handle sticky slightly differently from other browsers leading to occasional weird bugs. Without other leads (or our own macs), I think it's worth pursuing.

@ShouvikGhosh2048 do you think the code could be altered to avoid sticky? That might make the problem go away. I haven't played much with the other position values myself.

@ShouvikGhosh2048
Copy link
Collaborator

If we don't need to keep the headers at the top while scrolling, we can use position: static.

If we need to keep them at the top, then I think we can set the scroll area as position: relative and the headers as position: absolute (we'll also need to add padding at the top to move the rows down)? Does position: absolute/relative work on Safari?

@otobot1
Copy link
Member

otobot1 commented Apr 5, 2024

We do need to keep them at the top I think. As far as I can tell, it seems to just be sticky that has issues in safari.

@ShouvikGhosh2048
Copy link
Collaborator

ShouvikGhosh2048 commented Apr 8, 2024

I tried using position: absolute but couldn't make it work. What happens when you scroll down - does the table header move up?

@otobot1
Copy link
Member

otobot1 commented Apr 8, 2024

I tried using position: absolute but couldn't make it work. What happens when you scroll down - does the table header move up?

Ideally it should behave like it does now: the table header just stays with the top of the table. If the whole table area scrolls up, the table header goes up with it.

@otobot1
Copy link
Member

otobot1 commented Apr 15, 2024

If we are able to at least cover up the rows so they don't show in the gap between the table header and the difficulty tabs, that is good enough for v0.1.1. Actually dealing with the gap can be left as a follow-up issue if this winds up being our last v0.1.1 issue.

@otobot1
Copy link
Member

otobot1 commented Jun 1, 2024

My plan for v0.1.1 is to simply add a "known issues" section to the FAQ. Once that's done, this issue can be removed from the v0.1.1 milestone. Edit: #817 has been merged.

otobot1 added a commit that referenced this issue Jun 2, 2024
- split FAQ page into 2 columns
- add #724 to known issues
@otobot1 otobot1 modified the milestones: v0.1.1, v0.1.2 Jun 2, 2024
@otobot1 otobot1 modified the milestones: v0.1.2, v0.2.0 Jun 13, 2024
@otobot1 otobot1 modified the milestones: v0.2.0, v0.4.0 Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: very high status: help wanted This issue is low-priority for maintainers. Any user is welcome to submit a pull request type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants