Skip to content

Commit 3ae144e

Browse files
committed
fix workflow
1 parent f591661 commit 3ae144e

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

.github/workflows/celest_core.yaml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ jobs:
3333
run: dart format --set-exit-if-changed .
3434
test_darwin:
3535
needs: analyze_and_format
36-
runs-on: macos-13-large
37-
timeout-minutes: 10
36+
runs-on: macos-latest-xlarge
37+
timeout-minutes: 20
3838
steps:
3939
- name: Git Checkout
4040
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # 4.1.1
@@ -52,9 +52,13 @@ jobs:
5252
working-directory: packages/celest_core/example
5353
run: flutter pub get
5454
- name: Setup iOS Simulator
55-
uses: aws-amplify/amplify-flutter/.github/composite_actions/launch_ios_simulator@main
56-
with:
57-
ios-version: 17
55+
run: |
56+
RUNTIME=$(xcrun simctl list runtimes | grep 17 | tail -n 1 | cut -d' ' -f 7)
57+
echo "Using runtime: $RUNTIME"
58+
xcrun simctl create ios 'iPhone 15 Pro Max' $RUNTIME
59+
echo "Booting simulator"
60+
xcrun simctl boot ios
61+
echo "Booted simulator"
5862
- name: Test (iOS)
5963
working-directory: packages/celest_core/example
6064
run: flutter test -d test integration_test/secure_storage_test.dart
@@ -78,7 +82,7 @@ jobs:
7882
working-directory: packages/celest_core/example
7983
run: flutter pub get
8084
- name: Test (Android)
81-
uses: aws-amplify/amplify-flutter/.github/composite_actions/launch_android_emulator@main
85+
uses: ReactiveCircus/android-emulator-runner@6b0df4b0efb23bb0ec63d881db79aefbc976e4b2 # 2.30.1
8286
with:
8387
# Matches `package:jni` compileSdkVersion
8488
# https://github.com/dart-lang/native/blob/001910c9f40d637cb25c19bb500fb89cebdf7450/pkgs/jni/android/build.gradle#L57C23-L57C25

packages/celest_core/android/src/main/kotlin/dev/celest/celest_core/CelestSecureStorage.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class CelestSecureStorage(private val mainActivity: Activity, private val scope:
3838
}
3939
}
4040

41-
fun read(dataKey: String): String? = sharedPreferences.
41+
fun read(dataKey: String): String? = sharedPreferences.getString(dataKey, null)
4242

4343
fun delete(dataKey: String): String? {
4444
val current = read(dataKey)

0 commit comments

Comments
 (0)