Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Webfonts should not be defined in pixels #228

Open
nico3333fr opened this issue Oct 18, 2018 · 2 comments
Open

Webfonts should not be defined in pixels #228

nico3333fr opened this issue Oct 18, 2018 · 2 comments
Assignees
@scottaohara
Labels
enhancement general enhancement tag. use on anything needing to be enhanced. needs work not broken. but not necessarily done. more work needed.

Comments

@nico3333fr
Copy link

Issue

Use em/rem/whatever but not pixels for font-size declarations for the website a11y-style-guide.

Example

I've noticed some #kss-node .kss-description h3 defined in pixels and other examples. You should defined them in em or rem.

Cheers!
@cehfisher
Copy link
Owner

I am using the theme I created to override those elements. This allows me to easily update KSS node when I need to, but keep my overrides in place.

@nico3333fr
Copy link
Author

Wait, I'm not sure I understand: KSS overrides or your theme should override KSS?

px

@scottaohara scottaohara self-assigned this Oct 19, 2018
@scottaohara scottaohara added enhancement general enhancement tag. use on anything needing to be enhanced. needs work not broken. but not necessarily done. more work needed. labels Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@scottaohara scottaohara

Labels
enhancement general enhancement tag. use on anything needing to be enhanced. needs work not broken. but not necessarily done. more work needed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nico3333fr @scottaohara @cehfisher