listmgr: Remove final reference of my_bool #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function db_connect() which has a reference to data type 'my_pool' was added via commit 2d1de16 on 03 Aug 2010. Subsequently, via patch 6c174bd2a59d dated 24 Feb 2017 all "my_bool" defined was replaced via data type bool. However, the current build is failing with 'unknown type' as below under machine configuration show below that. *** Build error *** mysql_wrapper.c: In function ‘db_connect’: error: unknown type name ‘my_bool’; did you mean ‘bool’? my_bool reconnect = 1; ******************* $ gcc --version | grep GCC gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-18) $ uname -r 4.18.0-425.3.1.el8_lustre.x86_64 $ cat /etc/rocky-release Rocky Linux release 8.7 (Green Obsidian) $ git log --format=oneline -1 509584b (origin/master, origin/HEAD, master) \ policies: implement asc/desc modifier for sort order This patch replaces _single_ reference to "my_bool" with bool making the build pass and looks like type 'my_bool' is not used anymore. Change-Id: I88d8dcdbb49370e8d09d669c523d69a277adc148 Signed-off-by: Arshad Hussain <[email protected]>
|
Ping for review. Thanks |
|
Thank you for reporting and contributing. When building on el8.8 I don't get such error. |
|
Sorry, I should have mentioned in the bug info. It is influxdb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function db_connect() which has a reference to
data type 'my_pool' was added via commit 2d1de16
on 03 Aug 2010.
Subsequently, via patch 6c174bd2a59d dated 24 Feb 2017
all "my_bool" defined was replaced via data type bool.
However, the current build is failing with 'unknown type' as
below under machine configuration show below that.
*** Build error ***
mysql_wrapper.c: In function ‘db_connect’:
error: unknown type name ‘my_bool’; did you mean ‘bool’?
my_bool reconnect = 1;
$ gcc --version | grep GCC
gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-18)
$ uname -r
4.18.0-425.3.1.el8_lustre.x86_64
$ cat /etc/rocky-release
Rocky Linux release 8.7 (Green Obsidian)
$ git log --format=oneline -1
509584b (origin/master, origin/HEAD, master)
policies: implement asc/desc modifier for sort order
This patch replaces single reference to "my_bool" with
bool making the build pass and looks like type 'my_bool'
is not used anymore.
Change-Id: I88d8dcdbb49370e8d09d669c523d69a277adc148