Fixed all ESLint issues

Author: nicolasgarnier

Diff for: authenticated-json-api/functions/index.js

@@ -39,8 +39,10 @@ const authenticate = async (req, res, next) => {
     const decodedIdToken = await admin.auth().verifyIdToken(idToken);
     req.user = decodedIdToken;
     next();
+    return;
   } catch(e) {
     res.status(403).send('Unauthorized');
+    return;
   }
 };
 
@@ -103,7 +105,7 @@ app.get('/message/:messageId', async (req, res) => {
     return res.set('Cache-Control', 'private, max-age=300');
   } catch(error) {
     console.log('Error getting message details', messageId, error.message);
-    res.sendStatus(500);
+    return res.sendStatus(500);
   }
 });
 

Diff for: authorized-https-endpoint/functions/index.js

@@ -60,9 +60,11 @@ const validateFirebaseIdToken = async (req, res, next) => {
     console.log('ID Token correctly decoded', decodedIdToken);
     req.user = decodedIdToken;
     next();
+    return;
   } catch (error) {
     console.error('Error while verifying Firebase ID token:', error);
     res.status(403).send('Unauthorized');
+    return;
   }
 };
 

Diff for: child-count/functions/index.js

@@ -40,6 +40,7 @@ exports.countlikechange = functions.database.ref('/posts/{postid}/likes/{likeid}
         return (current || 0) + increment;
       });
       console.log('Counter updated.');
+      return null;
     });
 
 // If the number of likes gets deleted, recount the number of likes
@@ -50,5 +51,5 @@ exports.recountlikes = functions.database.ref('/posts/{postid}/likes_count').onD
   // Return the promise from counterRef.set() so our function
   // waits for this async event to complete before it exits.
   const messagesData = await collectionRef.once('value');
-  await counterRef.set(messagesData.numChildren());
+  return await counterRef.set(messagesData.numChildren());
 });

Diff for: convert-images/functions/index.js

@@ -65,4 +65,5 @@ exports.imageToJPG = functions.storage.object().onFinalize(async (object) => {
   // Once the image has been converted delete the local files to free up disk space.
   fs.unlinkSync(tempLocalJPEGFile);
   fs.unlinkSync(tempLocalFile);
+  return null;
 });

Diff for: coupon-on-purchase/functions/index.js

@@ -72,6 +72,7 @@ async function sendCouponViaFCM(uid, userLanguage) {
     // Send notifications to all tokens.
     return admin.messaging().sendToDevice(tokens, payload);
   }
+  return null;
 }
 
 /**
@@ -105,6 +106,7 @@ async function sendHighValueCouponViaFCM(uid, userLanguage) {
     // Send notifications to all tokens.
     return admin.messaging().sendToDevice(tokens, payload);
   }
+  return null;
 }
 
 /**

Diff for: crashlytics-integration/jira-issue/functions/index.js

@@ -40,7 +40,7 @@ function calculateIssuePriority(eventType) {
     // new issues - return low priority
     return 4;
   }
-};
+}
 
 // Helper function that parses the Jira project url and returns an object
 // of the url fragments
@@ -52,7 +52,7 @@ function parseUrl(url) {
   } else {
     throw new Error('Unexpected URL Format');
   }
-};
+}
 
 // Helper function that posts to Jira to create a new issue
 function createJiraIssue(summary, description, priority) {
@@ -96,7 +96,7 @@ function createJiraIssue(summary, description, priority) {
     body: newIssue,
     json: true,
   });
-};
+}
 
 exports.createNewIssue = functions.crashlytics.issue().onNew(async (issue) => {
   const issueId = issue.issueId;

Diff for: crashlytics-integration/slack-notifier/functions/index.js

@@ -30,7 +30,7 @@ function notifySlack(slackMessage) {
     },
     json: true,
   });
-};
+}
 
 exports.postOnNewIssue = functions.crashlytics.issue().onNew(async (issue) => {
   const issueId = issue.issueId;

Diff for: delete-unused-accounts-cron/functions/index.js

@@ -48,6 +48,7 @@ exports.accountcleanup = functions.https.onRequest(async (req, res) => {
   await promisePool.start();
   console.log('User cleanup finished');
   res.send('User cleanup finished');
+  return null;
 });
 
 /**
@@ -59,9 +60,9 @@ function deleteInactiveUser(inactiveUsers) {
 
     // Delete the inactive user.
     return admin.auth().deleteUser(userToDelete.uid).then(() => {
-      console.log('Deleted user account', userToDelete.uid, 'because of inactivity');
+      return console.log('Deleted user account', userToDelete.uid, 'because of inactivity');
     }).catch((error) => {
-      console.error('Deletion of inactive user account', userToDelete.uid, 'failed:', error);
+      return console.error('Deletion of inactive user account', userToDelete.uid, 'failed:', error);
     });
   } else {
     return null;

Diff for: email-confirmation/functions/index.js

@@ -58,4 +58,5 @@ exports.sendEmailConfirmation = functions.database.ref('/users/{uid}').onWrite(a
   } catch(error) {
     console.error('There was an error while sending the email:', error);
   }
+  return null;
 });

Diff for: exif-images/functions/index.js

@@ -57,7 +57,7 @@ exports.metadata = functions.storage.object().onFinalize(async (object) => {
   // Cleanup temp directory after metadata is extracted
   // Remove the file from temp directory
   await fs.unlinkSync(tempLocalFile)
-  console.log('cleanup successful!');
+  return console.log('cleanup successful!');
 });
 
 /**

Diff for: ffmpeg-convert-audio/functions/index.js

@@ -82,5 +82,5 @@ exports.generateMonoAudio = functions.storage.object().onFinalize(async (object)
   fs.unlinkSync(tempFilePath);
   fs.unlinkSync(targetTempFilePath);
 
-  console.log('Temporary files removed.', targetTempFilePath);
+  return console.log('Temporary files removed.', targetTempFilePath);
 });

Diff for: fulltext-search-firestore/functions/index.js

@@ -70,10 +70,10 @@ async function getFirebaseUser(req, res, next) {
     const decodedIdToken = admin.auth().verifyIdToken(idToken);
     console.log('ID Token correctly decoded', decodedIdToken);
     req.user = decodedIdToken;
-    next();
+    return next();
   } catch(error) {
     console.error('Error while verifying Firebase ID token:', error);
-    res.status(403).send('Unauthorized');
+    return res.status(403).send('Unauthorized');
   }
 }
 // [END get_firebase_user]

Diff for: generate-thumbnail/functions/index.js

@@ -49,14 +49,12 @@ exports.generateThumbnail = functions.storage.object().onFinalize(async (object)
 
   // Exit if this is triggered on a file that is not an image.
   if (!contentType.startsWith('image/')) {
-    console.log('This is not an image.');
-    return null;
+    return console.log('This is not an image.');
   }
 
   // Exit if the image is already a thumbnail.
   if (fileName.startsWith(THUMB_PREFIX)) {
-    console.log('Already a Thumbnail.');
-    return null;
+    return console.log('Already a Thumbnail.');
   }
 
   // Cloud Storage files.
@@ -99,5 +97,5 @@ exports.generateThumbnail = functions.storage.object().onFinalize(async (object)
   const fileUrl = originalResult[0];
   // Add the URLs to the Database
   await admin.database().ref('images').push({path: fileUrl, thumbnail: thumbFileUrl});
-  console.log('Thumbnail URLs saved to database.');
+  return console.log('Thumbnail URLs saved to database.');
 });

Diff for: github-to-slack/functions/index.js

@@ -42,10 +42,10 @@ exports.githubWebhook = functions.https.onRequest(async (req, res) => {
 
   try {
     await postToSlack(req.body.compare, req.body.commits.length, req.body.repository);
-    res.end();
+    return res.end();
   } catch(error) {
     console.error(error);
-    res.status(500).send('Something went wrong while posting the message to Slack.');
+    return res.status(500).send('Something went wrong while posting the message to Slack.');
   }
 });
 

Diff for: google-sheet-sync/functions/index.js

@@ -64,15 +64,15 @@ const DB_TOKEN_PATH = '/api_tokens';
 exports.oauthcallback = functions.https.onRequest(async (req, res) => {
   res.set('Cache-Control', 'private, max-age=0, s-maxage=0');
   const code = req.query.code;
-  functionsOauthClient.getToken(code, (err, tokens) => {
+  try {
+    const tokens = await functionsOauthClient.getToken(code);
     // Now tokens contains an access_token and an optional refresh_token. Save them.
-    if (err) {
-      return res.status(400).send(err);
-    }
     await admin.database().ref(DB_TOKEN_PATH).set(tokens);
     return res.status(200).send('App successfully configured with new Credentials. '
         + 'You can now close this page.');
-  });
+  } catch (error) {
+    return res.status(400).send(error);
+  }
 });
 
 // trigger function to write to Sheet when new data comes in on CONFIG_DATA_PATH

Diff for: google-sheet-sync/functions/package.json

@@ -4,7 +4,7 @@
   "dependencies": {
     "firebase-admin": "^5.13.1",
     "firebase-functions": "^2.0.0",
-    "google-auth-library": "^1.3.1",
+    "google-auth-library": "^1.6.1",
     "googleapis": "^27.0.0"
   },
   "devDependencies": {

Diff for: instagram-auth/functions/index.js

@@ -84,7 +84,7 @@ exports.token = functions.https.onRequest(async (req, res) => {
   const oauth2 = instagramOAuth2Client();
 
   try {
-    return cookieParser()(req, res, () => {
+    return cookieParser()(req, res, async () => {
       console.log('Received verification state:', req.cookies.state);
       console.log('Received state:', req.query.state);
       if (!req.cookies.state) {
@@ -108,12 +108,10 @@ exports.token = functions.https.onRequest(async (req, res) => {
       // Create a Firebase account and get the Custom Auth Token.
       const firebaseToken = await createFirebaseAccount(instagramUserID, userName, profilePic, accessToken);
       // Serve an HTML page that signs the user in and updates the user profile.
-      res.jsonp({
-        token: firebaseToken,
-      });
+      return res.jsonp({ token: firebaseToken});
     });
   } catch(error) {
-    res.jsonp({
+    return res.jsonp({
       error: error.toString(),
     });
   }

Diff for: limit-children/functions/index.js

@@ -36,4 +36,5 @@ exports.truncate = functions.database.ref('/chat/{messageid}').onWrite(async (ch
     // Update the parent. This effectively removes the extra children.
     return parentRef.update(updates);
   }
+  return null;
 });

Diff for: line-auth/functions/index.js

@@ -116,8 +116,7 @@ exports.verifyToken = functions.https.onRequest(async (req, res) => {
     const ret = {
       error_message: 'Access Token not found',
     };
-    res.status(400).send(ret);
-    return;
+    return res.status(400).send(ret);
   }
 
   const reqToken = req.body.token;
@@ -128,7 +127,7 @@ exports.verifyToken = functions.https.onRequest(async (req, res) => {
     const ret = {
       firebase_token: customAuthToken,
     };
-    res.status(200).send(ret);
+    return res.status(200).send(ret);
   } catch(err) {
     // If LINE access token verification failed, return error response to client
     const ret = {

Diff for: linkedin-auth/functions/index.js

@@ -107,9 +107,7 @@ exports.token = functions.https.onRequest((req, res) => {
       });
     });
   } catch (error) {
-    res.jsonp({
-      error: error.toString,
-    });
+    return res.jsonp({ error: error.toString });
   }
 });
 

Diff for: moderate-images/functions/index.js

@@ -38,6 +38,7 @@ exports.blurOffensiveImages = functions.storage.object().onFinalize(async (objec
   if (safeSearch.adult || safeSearch.violence) {
     return blurImage(object.name, object.bucket, object.metadata);
   }
+  return null;
 });
 
 /**

Diff for: nextjs-with-firebase-hosting/package.json

@@ -4,14 +4,14 @@
   "description": "Host Next.js SSR app on Firebase Cloud Functions with Firebase Hosting redirects.",
   "repository": "https://github.com/jthegedus/firebase-functions-next-example.git",
   "scripts": {
-    "install": "yarn build-all",
-    "next": "yarn build-firebase && cd \"src/app\" && yarn && yarn dev",
-    "preserve": "yarn build-all",
+    "install": "npm run build-all",
+    "next": "npm run build-firebase && cd \"src/app\" && npm install",
+    "preserve": "npm run build-all",
     "serve": "firebase serve",
-    "predeploy": "yarn build-all",
+    "predeploy": "npm run build-all",
     "deploy": "firebase deploy",
-    "build-all": "yarn build-next && yarn build-firebase",
-    "build-next": "cd \"src/app\" && yarn && yarn build",
-    "build-firebase": "cd \"src/functions\" && yarn"
+    "build-all": "npm run build-next && npm run build-firebase",
+    "build-next": "cd \"src/app\" && npm install && npm build",
+    "build-firebase": "cd \"src/functions\" && npm install"
   }
 }

Diff for: paypal/functions/.eslintrc.json

@@ -1,7 +1,7 @@
 {
   "parserOptions": {
     // Required for certain syntax usages
-    "ecmaVersion": 6
+    "ecmaVersion": 2017
   },
   "plugins": [
     "promise"

Diff for: quickstarts/thumbnails/functions/index.js

@@ -41,16 +41,14 @@ exports.generateThumbnail = functions.storage.object().onFinalize(async (object)
   // [START stopConditions]
   // Exit if this is triggered on a file that is not an image.
   if (!contentType.startsWith('image/')) {
-    console.log('This is not an image.');
-    return null;
+    return console.log('This is not an image.');
   }
 
   // Get the file name.
   const fileName = path.basename(filePath);
   // Exit if the image is already a thumbnail.
   if (fileName.startsWith('thumb_')) {
-    console.log('Already a Thumbnail.');
-    return null;
+    return console.log('Already a Thumbnail.');
   }
   // [END stopConditions]
 
@@ -75,7 +73,7 @@ exports.generateThumbnail = functions.storage.object().onFinalize(async (object)
     metadata: metadata,
   });
   // Once the thumbnail has been uploaded delete the local file to free up disk space.
-  fs.unlinkSync(tempFilePath);
+  return fs.unlinkSync(tempFilePath);
   // [END thumbnailGeneration]
 });
 // [END generateThumbnail]

Diff for: template-handlebars/functions/firebaseUser.js

@@ -31,7 +31,7 @@ async function validateFirebaseIdToken (req, res, next) {
     await addDecodedIdTokenToRequest(idToken, req);
   }
   next();
-};
+}
 
 /**
  * Returns a Promise with the Firebase ID Token if found in the Authorization or the __session cookie.