Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type of url fields is inconsistent into jsonschema #191

Open
davidB opened this issue Mar 7, 2024 · 2 comments
Open

type of url fields is inconsistent into jsonschema #191

davidB opened this issue Mar 7, 2024 · 2 comments
Labels
breaking change Indicates when a PR or issue will have breaking changes
Milestone

Comments

@davidB
Copy link
Contributor

davidB commented Mar 7, 2024

In the JSON schema, the type and format of some URL fields (subject.content.url, subject.content.wiewUrl) is not consistent. Is this expected?

And sometimes they are required with "minLength: 1" and sometimes required without minLength

The only url of type uri is in testsuiterunqueued.

IMHO:

  • every URL should be with format: "uri" (or uri-reference), and no minLength.
  • URL that should be purl, should be defined with a common type definition (maybe uri-template)

Side Notes:

related to #162

@afrittoli
Copy link
Contributor

Thanks, @davidB - would you like to propose a fix for this? We could target this for the v0.5 milestone.

@afrittoli afrittoli added this to the v0.5 milestone Apr 3, 2024
@davidB
Copy link
Contributor Author

davidB commented Apr 3, 2024

Ok, I'll try next WE.

@xibz xibz added the breaking change Indicates when a PR or issue will have breaking changes label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Indicates when a PR or issue will have breaking changes
Projects
None yet
Development

No branches or pull requests

3 participants