Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular dependency tracker #38

Open
aalmiray opened this issue Apr 27, 2023 · 6 comments
Open

Modular dependency tracker #38

aalmiray opened this issue Apr 27, 2023 · 6 comments

Comments

@aalmiray
Copy link
Contributor

Now that a full Java module descriptor is in place thanks to #16 it would also be a good idea to keep track of current dependencies (compile & runtime) to see which ones may need updates in terms of Java modules support. Consumers wishing to use cdevents with modular Java Runtimes (created with jlink) require dependencies with full module descriptors.

Current dependency graph (mvn dependency:tree)

dev.cdevents:cdevents-sdk-java:jar:0.1.0-SNAPSHOT
+- io.cloudevents:cloudevents-core:jar:2.3.0:compile
|  \- io.cloudevents:cloudevents-api:jar:2.3.0:compile
+- com.fasterxml.jackson.core:jackson-databind:jar:2.15.0:compile
|  +- com.fasterxml.jackson.core:jackson-annotations:jar:2.15.0:compile
|  \- com.fasterxml.jackson.core:jackson-core:jar:2.15.0:compile
+- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.15.0:compile
+- com.networknt:json-schema-validator:jar:1.0.80:compile
|  +- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.15.0:compile
|  |  \- org.yaml:snakeyaml:jar:2.0:compile
|  +- org.apache.commons:commons-lang3:jar:3.12.0:runtime
|  \- com.ethlo.time:itu:jar:1.7.0:compile
+- org.slf4j:slf4j-api:jar:2.0.7:compile
+- org.slf4j:slf4j-reload4j:jar:2.0.7:runtime
  \- ch.qos.reload4j:reload4j:jar:1.2.22:runtime

Module names per dependency

Dependency Module Name Source Fix
cloudevents-core-2.3.0 io.cloudevents.core manifest
cloudevents-api-2.3.0 io.cloudevents.api manifest
jackson-databind-2.15.0 com.fasterxml.jackson.databind explicit OK
jackson-annotations-2.15.0 com.fasterxml.jackson.annotation explicit OK
jackson-core-2.15.0 com.fasterxml.jackson.core explicit OK
jackson-datatype-jsr310-2.15.0 com.fasterxml.jackson.datatype.jsr310 explicit OK
json-schema-validator-1.0.80 json.schema.validator filename
jackson-dataformat-yaml-2.15.0 com.fasterxml.jackson.dataformat.yaml explicit OK
snakeyaml-2.0 org.yaml.snakeyaml explicit OK
commons-lang3-3.12.0 org.apache.commons.lang3 manifest
itu-1.7.0 itu filename
slf4j-api-2.0.7 org.slf4j explicit OK
slf4j-reload4j-2.0.7 slf4j.reload4j filename
reload4j-1.2.22 reload4j filename
@aalmiray
Copy link
Contributor Author

aalmiray commented Apr 27, 2023

@aalmiray
Copy link
Contributor Author

Depends on #39

@afrittoli
Copy link
Contributor

@aalmiray is this something you are still working on? It could be a candidate for hacktoberfest otherwise

@aalmiray
Copy link
Contributor Author

@aalmiray is this something you are still working on? It could be a candidate for hacktoberfest otherwise

@afrittoli I have not looked at the tracker in the past months, but it does make sense to promote it for Hacktoberfest as you suggest.

@aalmiray
Copy link
Contributor Author

aalmiray commented Feb 13, 2024

It seems reload4j will not jump to modules. I'd recommend removing any loggin framewrok from runtime dependencies as it's the job of the consuming project to determine which logging framework should be used.

For tests, this project could use slf4j-simple.

UPDATE: this is already done.

@aalmiray
Copy link
Contributor Author

commons-lang3-3.14.0 defines an explicit module descriptor. I suggest upgrading this dependency at your earliest convenience.

aalmiray added a commit to aalmiray/sdk-java that referenced this issue Feb 13, 2024
aalmiray added a commit to aalmiray/sdk-java that referenced this issue Feb 13, 2024
Related to cdevents#38

Signed-off-by: Andres Almiray <[email protected]>
rjalander pushed a commit that referenced this issue Feb 28, 2024
Related to #38

Signed-off-by: Andres Almiray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants