Merge pull request DesignPatternsPHP#476 from sjokkateer/improvement/EAV

EAV: Update missing type declarations

Author: Dominik Liebler

More/EAV/Attribute.php

@@ -15,7 +15,7 @@ public function __construct(private string $name)
         $this->values = new SplObjectStorage();
     }
 
-    public function addValue(Value $value)
+    public function addValue(Value $value): void
     {
         $this->values->attach($value);
     }

More/EAV/Entity.php

@@ -16,7 +16,7 @@ class Entity implements \Stringable
     /**
      * @param Value[] $values
      */
-    public function __construct(private string $name, $values)
+    public function __construct(private string $name, array $values)
     {
         $this->values = new SplObjectStorage();
 

More/EAV/Tests/EAVTest.php

@@ -11,7 +11,7 @@
 
 class EAVTest extends TestCase
 {
-    public function testCanAddAttributeToEntity()
+    public function testCanAddAttributeToEntity(): void
     {
         $colorAttribute = new Attribute('color');
         $colorSilver = new Value($colorAttribute, 'silver');