From 6d048e0288a39adc675efd8a075ea574f75f048e Mon Sep 17 00:00:00 2001 From: uncenter <47499684+uncenter@users.noreply.github.com> Date: Sun, 8 Sep 2024 12:31:26 -0400 Subject: [PATCH 1/2] fix: match tokens to style guide --- sass/_theme.scss | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sass/_theme.scss b/sass/_theme.scss index ab9ba64..023ae34 100644 --- a/sass/_theme.scss +++ b/sass/_theme.scss @@ -7,7 +7,7 @@ $highlights: ( "type": "yellow", "literal": "peach", "number": "peach", - "operator": "teal", + "operator": "sky", "punctuation": "subtext1", "property": "teal", "regexp": "pink", @@ -26,8 +26,8 @@ $highlights: ( "doctag": "red", "meta": "peach", "section": "blue", - "tag": "subtext0", - "name": "mauve", + "tag": "teal", + "name": "blue", "attr": "blue", "attribute": "green", "bullet": "teal", From f081a86c74cc8fb2a692a653fe3031c764517da1 Mon Sep 17 00:00:00 2001 From: uncenter <47499684+uncenter@users.noreply.github.com> Date: Sun, 8 Sep 2024 20:07:20 -0400 Subject: [PATCH 2/2] fix: revert `name` token change, add comment explanations --- sass/_theme.scss | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sass/_theme.scss b/sass/_theme.scss index 023ae34..9d2ddb4 100644 --- a/sass/_theme.scss +++ b/sass/_theme.scss @@ -27,7 +27,9 @@ $highlights: ( "meta": "peach", "section": "blue", "tag": "teal", - "name": "blue", + /* Should be blue as it themes HTML tags, but blue tags next to blue attributes names is hard to read (see `attr` below for blue attribute names). */ + "name": "mauve", + /* Should be yellow as it themes HTML attribute names, but it also themes YAML keys. Having innacurate YAML keys looks arguably worse than slightly bad attribute coloring, so blue it is. */ "attr": "blue", "attribute": "green", "bullet": "teal",