improve testdata files folder content

[ccoVeille]

Here is the current testdata folder structure

testdata/src
├── bool-format
│   ├── p.go
│   └── p.go.golden
├── default
│   ├── p.go
│   └── p.go.golden
├── err-error
│   ├── p.go
│   └── p.go.golden
├── errorf
│   ├── p.go
│   └── p.go.golden
├── error-format
│   ├── p.go
│   └── p.go.golden
(...)

Each p.go file contains a version of testdata/src/default/p.go that is slightly altered.

It's a burden to maintain the content of these files, I experienced it by working on

• fix: refactor unit tests so they don't depend on previous tests #44

I think code should be split into multiple file, for example one per type

integer.go
integer.go.golden
hex.go
hex.go.golden
bool.go
bool.go.golden
...
negative.go.golden
negative.go.golden
malformed.go.golden
malformed.go.golden

• integer.go would be about the code that is likely to be affected by integer-format in p.go
• hex.go would be about the code that is likely to be affected by hex-format in p.go
• ...
• negative.go would be about the code currently in func negative() in p.go
• malformed.go would be about the code currently in func malformed() in p.go

We could also consider using a different naming for file when they are altered

so testdata/src/default would contain

integer.go
integer.go.golden
hex.go
hex.go.golden
bool.go
bool.go.golden
...
negative.go.golden
negative.go.golden
malformed.go.golden
malformed.go.golden

While testdata/src/hex-format would contain

integer.go
integer.go.golden
hex_deactivated.go
hex_deactivated.go.golden
bool.go
bool.go.golden
...
negative.go.golden
negative.go.golden
malformed.go.golden
malformed.go.golden

This could prepare the work of generating the testdata and golden files, but it's not the purpose of this issue

Note

Note: This change is not directly linked to #47, but they will have to be done one after the other to avoid conflicts.

• improve testdata files folder structure #47

[catenacyber]

I think the best would be to have a unique p.go file and have the right tooling to update all the golden test files for all options

[ccoVeille]

I preferred my approach of having two files per checker:

• one with option activated
• one with checker deactivated

The invariant files that are should catch nothing. Then a way to copy the right file at the right place.

But why not. My problem is that generating test and golden files is never fun.

It's better to do not reinvent the wheel. Let's reuse something that exists

Any idea how to that @alexandear @mmorel-35 ?

[alexandear]

Any idea how to that

Thanks for improving testdata folder. I haven't contributed much to this repo, so I'm not in a position to make decisions about the preferred approach.