Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixed language/country codes in locale directory #113

Open
adonishi opened this issue Jan 7, 2013 · 2 comments
Open

mixed language/country codes in locale directory #113

adonishi opened this issue Jan 7, 2013 · 2 comments

Comments

@adonishi
Copy link

adonishi commented Jan 7, 2013

(this issue related to issue #100 )

in the directory of /locale in carmen, there are 2-letter code directories for each languages. (I guess they are languages and not countries. fix me if I am wrong.)
but some of directory names are country code, not language code.

so far country codes are 'China' & 'Japan'. they should be 'Chinese' & 'Japanese'. ('zh' & 'ja')

list of names in /locale directory.

  • cn:country 'China' (lang = zh )
  • cs:lang 'Czech'
  • de:lang/country 'German/Germany'
  • en:lang 'English'
  • es:lang/country 'Spanish; Castilian/Spain'
  • fi:lang/country 'Finnish/Finland'
  • fr:lang/country 'French/France'
  • hi:lang 'Hindi'
  • it:lang/country 'Italian/Italy'
  • jp:country 'Japan' (lang = ja)
  • ko:lang 'Korean'
  • nl:lang/country 'Dutch/Netherlands'
  • pl:lang/country 'Polish/Poland'
  • pt:lang/country 'Portuguese/Portugal'
  • ru:lang/country 'Russian/Russian Federation'
  • sk:lang/country 'Slovak/Slovakia'
  • sv:lang(/country) 'Swedish(/El Salvador)'
  • tr:lang/country 'Turkish/Turkey'

ref.
language tag ISO-639-1
http://en.wikipedia.org/wiki/List_of_ISO_639-1_codes
country code ISO-3166-1
http://en.wikipedia.org/wiki/ISO_3166-1

@adonishi
Copy link
Author

adonishi commented Jan 8, 2013

Sorry! I made one mistake!
Chinese language 2-letter code is 'zh' (not 'cn').
so...

so far country codes are 'China' & 'Japan'. they should be 'Chinese' & 'Japanese'. ('zh' & 'ja')

and

  • cn:country 'China' (lang = zh )

@jim
Copy link
Collaborator

jim commented Mar 5, 2014

You are correct. The locale/ directory does use country codes where it should use language codes. I'll have to write a little code to make these changes backwards-compatible, but it does seem like standardizing on language codes is worthwhile. Thanks for reporting this issue.

@jim jim added the enhancement label Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants