Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#EXT-X-DATERANGE limited to 1 per media segment #37

Open
NFLjmarkarian opened this issue Jun 21, 2021 · 2 comments
Open

#EXT-X-DATERANGE limited to 1 per media segment #37

NFLjmarkarian opened this issue Jun 21, 2021 · 2 comments

Comments

@NFLjmarkarian
Copy link

First off, great library, it's very useful!

I have an issue where I need to add multiple dateRange objects within a playlist. (For simplicity, let's say it's an example where I have 1 media segment that is 10 seconds long, and I want to fire timed meta data at the 0 second mark and the 5 second mark).

Currently, there is no way to do this, as dateRange is a single attribute of MediaSegmentBuilder. I am only able to associate 1 dateRange object with 1 Media Segment.

According to the spec, I think dateRange should not be an attribute of MediaSegmentBuilder, but instead, MediaPlaylist.Builder and should be a collection: https://datatracker.ietf.org/doc/html/rfc8216#section-4.3.2.7

Alternatively, I considered two other solutions:

  1. Change the dateRange attribute on MediaSegmentBuilder to be a collection
    or
  2. Allow the creation of Media Segments without a duration/uri (which is currently required), and create Media Segment containers that are essentially empty except for 1 date range attribute.

What are your thoughts?

@carlanton
Copy link
Owner

Hi!

Thank you for your feedback. I haven't really used that tag myself but if you think it make sense to have multiple tags for a single segment, let's do it! :)

EXT-X-DATERANGE is defined under "4.3.2 Media Segment Tags", why do you think that it it's better to store it in MediaPlaylist.Builder?

I think I want to go with option 1 (change it to a collection), but add methods to keep backwards compatibility. Not sure if I understand option 2 though...

Cheers,
Anton

@wishygupta
Copy link

wishygupta commented Aug 23, 2022

@carlanton Thank you for making this library. Have been very useful.
Even I have this requirement where I need to add multiple date range. Having a collection for date range would be much better.
Any plans on it?
@NFLjmarkarian how did you do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants