Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React|WC Parity: Slider #18247

Open
sangeethababu9223 opened this issue Dec 12, 2024 · 3 comments · May be fixed by #18464
Open

React|WC Parity: Slider #18247

sangeethababu9223 opened this issue Dec 12, 2024 · 3 comments · May be fixed by #18464
Assignees
@sangeethababu9223
Labels
package: @carbon/web-components @carbon/web-components role: dev 🤖

Comments

@sangeethababu9223
Copy link
Member

sangeethababu9223 commented Dec 12, 2024 •
edited by tay1orjones
Loading

See parent issue #17992 for acceptance criteria.

This work had already been completed in the Dotcom library, but was not merged before @carbon/web-components was migrated here. All of the work can be re-used, keeping in mind that Lit is now using v3 (previous work was build while still on Lit 2):

carbon-design-system/carbon-for-ibm-dotcom#11567

Important

Every PR needs a ux and visual review from the design team to ensure consistency. Please be sure PRs have status: visual review 🔍 applied and request a review from @carbon-design-system/design
@kennylam kennylam moved this to ⏱ Backlog in Design System Dec 13, 2024
@sangeethababu9223 sangeethababu9223 moved this from ⏱ Backlog to 🏗 In Progress in Design System Dec 19, 2024
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Jan 3, 2025
@elycheea elycheea moved this from Needs triage 🧐 to In progress in Carbon for IBM Products Jan 3, 2025
@sangeethababu9223 sangeethababu9223 mentioned this issue Jan 6, 2025
Closed
@sangeethababu9223
Copy link
Member Author

Compared to the React counterpart, the Web Components Storybook is missing the following stories:

  • Slider With Custom Value Label
  • Slider With Hidden Inputs
  • Two Handle Skeleton
  • Two Handle Slider
  • Two Handle Slider With Hidden Inputs

@tay1orjones
Copy link
Member

@sangeethababu9223

Important

Every PR needs a ux and visual review from the design team to ensure consistency. Please be sure PRs have status: visual review 🔍 applied and request a review from @carbon-design-system/design

@sangeethababu9223 sangeethababu9223 mentioned this issue Jan 22, 2025
Closed
@sangeethababu9223
Copy link
Member Author

@sangeethababu9223

Important

Every PR needs a ux and visual review from the design team to ensure consistency. Please be sure PRs have status: visual review 🔍 applied and request a review from @carbon-design-system/design

Hi @tay1orjones,
It looks like I don't have the permission to set labels for the PRs.

@sangeethababu9223 sangeethababu9223 linked a pull request Jan 29, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangeethababu9223 sangeethababu9223

Labels
package: @carbon/web-components @carbon/web-components role: dev 🤖
Projects
Carbon for IBM Products
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(slider): resolve parity issue two handle skeleton sangeethababu9223/carbon
3 participants
@kennylam @tay1orjones @sangeethababu9223