Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test setup #78

Merged
merged 21 commits into from
Dec 3, 2024
Merged

Test setup #78

merged 21 commits into from
Dec 3, 2024

Conversation

navinkrishnan
Copy link
Contributor

  • Test files moved to test
  • test file copy the needed cds files into srv
  • some tests starts in own context (remote-service, messaging)

@navinkrishnan
dev dependencies
47c75fb
@navinkrishnan
Test setup
23531c7 
* Test files moved to test/
* test copy the needed files
* some tests starts in own context (remote-service, messaging)
@navinkrishnan
Merge branch 'main' of https://github.com/cap-js/incidents-app into t…
34cd6d1 
…est-checkout
@navinkrishnan
resolved conflicts
ecd9601
@navinkrishnan
included attchments test
f8becf0
@navinkrishnan navinkrishnan requested a review from danjoa October 14, 2024 04:28
@danjoa
Copy link
Contributor

danjoa commented Nov 7, 2024 •
edited
Loading

@navinkrishnan @DanSchlachter I finally found some spare time to review and did some simplifications, mainly by using cds.utils.copy() and .rm(). The rest of the changes are of rather cosmetic nature.

We need to follow up on that still overly complex setup with .gtihub/checkout and related plethora of npm scripts as well as the polluted package.json's in general

@navinkrishnan
Copy link
Contributor Author

@danjoa Thank you for your valuable inputs. The simplified .github/checkout works as expected and I'll also make sure further tests includes similar pattern.
For the REVISIT comments, I will setup a separate discussion to see how this can be modified as per best practices.

If no further comments, can you please approve this PR for the merge ?

@danjoa danjoa enabled auto-merge December 3, 2024 16:15
@danjoa danjoa merged commit d8ece8c into main Dec 3, 2024
4 checks passed
@danjoa danjoa deleted the test-checkout branch December 3, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjoa danjoa danjoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navinkrishnan @danjoa