Manage tap of expense

Author: cp-nirali-s

Data/Data/Store/ExpenseStore.swift

@@ -76,7 +76,10 @@ public class ExpenseStore: ObservableObject {
 
         let fetchedExpenses = expenseSnapshot.documents.compactMap { doc -> Expense? in
             do {
-                return try doc.data(as: Expense.self)
+                var expense = try doc.data(as: Expense.self)
+                let groupId = doc.reference.parent.parent?.documentID ?? "" // Extract groupId
+                expense.groupId = groupId
+                return expense
             } catch {
                 LogE("ExpenseStore: \(#function) Error decoding expense: \(error.localizedDescription)")
                 return nil

Splito/UI/Home/ActivityLog/Search/SearchExpensesView.swift

@@ -71,7 +71,7 @@ private struct ExpenseListView: View {
                                 GroupExpenseItemView(expenseWithUser: expense,
                                                      isLastItem: expense.expense == (viewModel.groupExpenses[month] ?? []).last?.expense)
                                 .onTouchGesture {
-                                    viewModel.handleExpenseItemTap(expenseId: expense.expense.id ?? "")
+                                    viewModel.handleExpenseItemTap(expense: expense.expense)
                                 }
                                 .id(expense.expense.id)
                             }

Splito/UI/Home/ActivityLog/Search/SearchExpensesViewModel.swift

@@ -40,6 +40,9 @@ class SearchExpensesViewModel: BaseViewModel, ObservableObject {
         self.router = router
         super.init()
 
+        NotificationCenter.default.addObserver(self, selector: #selector(handleUpdateExpense(notification:)), name: .updateExpense, object: nil)
+        NotificationCenter.default.addObserver(self, selector: #selector(handleDeleteExpense(notification:)), name: .deleteExpense, object: nil)
+
         fetchInitialExpenses()
     }
 
@@ -152,8 +155,42 @@ class SearchExpensesViewModel: BaseViewModel, ObservableObject {
     }
 
     // MARK: - User Actions
-    func handleExpenseItemTap(expenseId: String) {
-        //        router.push(.ExpenseDetailView(groupId: groupId, expenseId: expenseId))
+    func handleExpenseItemTap(expense: Expense) {
+        if let groupId = expense.groupId, let expenseId = expense.id {
+            router.push(.ExpenseDetailView(groupId: groupId, expenseId: expenseId))
+        }
+    }
+
+    @objc func handleUpdateExpense(notification: Notification) {
+        guard var updatedExpense = notification.object as? Expense else { return }
+
+        if let index = expenses.firstIndex(where: { $0.id == updatedExpense.id }) {
+            expenses[index] = updatedExpense
+        }
+
+        Task { [weak self] in
+            if let user = await self?.fetchMemberData(for: updatedExpense.paidBy.keys.first ?? "") {
+                if let index = self?.expensesWithUser.firstIndex(where: { $0.expense.id == updatedExpense.id }) {
+                    let updatedExpenseWithUser = ExpenseWithUser(expense: updatedExpense, user: user)
+                    withAnimation {
+                        self?.expensesWithUser[index] = updatedExpenseWithUser
+                        self?.updateGroupExpenses()
+                    }
+                }
+            }
+        }
+    }
+
+    @objc func handleDeleteExpense(notification: Notification) {
+        guard let deletedExpense = notification.object as? Expense else { return }
+        expenses.removeAll { $0.id == deletedExpense.id }
+        if let index = expensesWithUser.firstIndex(where: { $0.expense.id == deletedExpense.id }) {
+            withAnimation {
+                expensesWithUser.remove(at: index)
+                updateGroupExpenses()
+                showToastFor(toast: .init(type: .success, title: "Success", message: "Expense deleted successfully."))
+            }
+        }
     }
 
     // MARK: - Error Handling

firestore.rules

@@ -42,7 +42,8 @@ service cloud.firestore {
 
     // For Groups Collection
     match /groups/{groupId} {
-    	allow read: if true;
+      allow read: if isAuthorized() &&
+                     resource.data.members.hasAny([request.auth.uid]);
 
       allow create: if isAuthorized() &&
       				   isCurrentUser(request.resource.data.created_by);
@@ -60,7 +61,7 @@ service cloud.firestore {
 
     // For Expenses Collection
     match /groups/{groupId}/expenses/{expenseId} {
-      	allow read: if true;
+      	allow read: if isUserPartOfGroup(groupId);
 
       	allow create: if isCurrentUser(request.resource.data.added_by) &&
         				 isUserPartOfGroup(groupId);