Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Custom partitioning requires to use the change button #1203

Open
seb128 opened this issue Oct 21, 2022 · 3 comments · May be fixed by #1287
Open

Custom partitioning requires to use the change button #1203

seb128 opened this issue Oct 21, 2022 · 3 comments · May be fixed by #1287

Comments

@seb128
Copy link
Collaborator

seb128 commented Oct 21, 2022

The old desktop installer let you right or double click on a partition line to edit it which requires less mouse movement than selecting and having to go to the button

jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 4, 2023
@jpnurmi jpnurmi linked a pull request Jan 4, 2023 that will close this issue
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this issue Jan 4, 2023
@jpnurmi
Copy link
Contributor

jpnurmi commented Jan 11, 2023

@seb128 @kenvandine @elioqoshi

Due to how gesture negotiation works in Flutter, handling double-clicks in the manual partitioning table adds 300ms delay to single-clicks. There's a well-noticeable and somewhat annoying delay when selecting rows or checking the "Format" checkboxes. Adding new partitions and editing existing ones by double-clicking is much more convenient, but it makes all other interactions within the table feel sluggish.

Should we give it a try so you can all get a feeling? We can revert it the next day if you don't like it...

image

@elioqoshi
Copy link

Can we have both options? Also double clicking and selecting + button?

@jpnurmi
Copy link
Contributor

jpnurmi commented Jan 11, 2023

Yes, the old select+button functionality will be kept. 👍 Double-click is just a shortcut (with an unfortunate side-effect).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants