Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot select from tooltip #4834

Closed
nikku opened this issue Feb 14, 2025 · 4 comments
Closed

Cannot select from tooltip #4834

nikku opened this issue Feb 14, 2025 · 4 comments
Assignees
Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Milestone

Comments

@nikku
Copy link
Member

nikku commented Feb 14, 2025

Describe the bug

In many places in the properties panels we show examples (i.e. for the timer event). However, these examples are often times meaningless, because I cannot select / copy from a tooltip. I have to replicate (type them), which is hard / error prone or open the external documentation link, just to copy the same examples from there:

Image

Steps to reproduce

  1. Model a timer start event
  2. Add timer ("Date")
  3. Try to fill value field, with help from tooltip

Expected behavior

I am able to select contents of a tooltip, so they are helpful.

Alternatively we could consider that our tooling is generally more helpful, i.e. for date fields, or duration fields it could offer patterns or a selection UI. This would not be a general solution to this problem though.

Environment

  • OS: Any
  • Camunda Modeler Version: v5.32.0
  • Execution Platform: Camunda 8 / Any
  • Installed plug-ins: None

Additional context

No response

@nikku nikku added the bug Something isn't working label Feb 14, 2025
@barmac
Copy link
Collaborator

barmac commented Feb 14, 2025

We could alternatively allow to copy via click on code, but I think it's better to simply allow selection and copy. The former is easy to implement, so I'm adding this to spring cleaning list.

@barmac barmac added the spring cleaning Could be cleaned up one day label Feb 14, 2025
@nikku nikku added the backlog Queued in backlog label Feb 17, 2025 — with bpmn-io-tasks
@jarekdanielak jarekdanielak self-assigned this Feb 19, 2025
@jarekdanielak jarekdanielak added the ready Ready to be worked on label Feb 19, 2025 — with bpmn-io-tasks
@jarekdanielak jarekdanielak removed the backlog Queued in backlog label Feb 19, 2025
@jarekdanielak
Copy link
Contributor

I can actually select in the bpmn-js-properties-panel tooltip, but not in the Desktop Modeler.

Screen.Recording.2025-02-19.at.11.13.44.mov

@nikku
Copy link
Member Author

nikku commented Feb 19, 2025

I can actually select in the bpmn-js-properties-panel tooltip, but not in the Desktop Modeler.

Very likely due to rigid user-select: none then, enforced in Desktop Modeler.

jarekdanielak added a commit that referenced this issue Feb 20, 2025
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed ready Ready to be worked on needs review Review pending labels Feb 20, 2025
jarekdanielak added a commit to bpmn-io/properties-panel that referenced this issue Feb 20, 2025
chore: refactor Tooltip component to rely on React event handlers

Related to camunda/camunda-modeler#4834
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 20, 2025
jarekdanielak added a commit to bpmn-io/properties-panel that referenced this issue Feb 20, 2025
chore: refactor Tooltip component to rely on React event handlers

Related to camunda/camunda-modeler#4834
barmac pushed a commit that referenced this issue Feb 21, 2025
@jarekdanielak
Copy link
Contributor

Closed with #4841, and it followed up with a bugfix in bpmn-io/properties-panel#399

@jarekdanielak jarekdanielak added this to the M86 milestone Feb 21, 2025
@nikku nikku closed this as completed Feb 21, 2025
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 21, 2025
jarekdanielak added a commit to bpmn-io/properties-panel that referenced this issue Feb 21, 2025
chore: refactor Tooltip component to rely on React event handlers

Related to camunda/camunda-modeler#4834
jarekdanielak added a commit to bpmn-io/properties-panel that referenced this issue Feb 21, 2025
chore: refactor Tooltip component to rely on React event handlers

Related to camunda/camunda-modeler#4834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

3 participants