Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to only sync medium #52

Open
hbredin opened this issue Jun 28, 2017 · 2 comments
Open

Add option to only sync medium #52

hbredin opened this issue Jun 28, 2017 · 2 comments

Comments

@hbredin
Copy link
Member

hbredin commented Jun 28, 2017

(related to #51)

Right now, we can either sync-current-time, sync-playing or both (with sync-all).
All three options actually sync the medium as well.

There should be a way to only sync the medium (hence its URL) when you don't want to sync anything...

// only sync the medium
<camomile-player [...] src="mediumView"></camomile-player>

// sync the medium and its "currentTime" property
<camomile-player [...] src="mediumView" sync-current-time="mediumView"></camomile-player>

// sync the medium and all its properties
<camomile-player [...] src="mediumView" sync-all="mediumView"></camomile-player>

// this could be also supported and would be equivalent 
// here, True would mean "sync-all = src"
<camomile-player [...] src="mediumView" sync-all=True></camomile-player>

// but this could be also possible:
<camomile-player [...] src="mediumView" sync-all="anotherMediumView"></camomile-player>

cc @PaulAlbert31

@rom1504
Copy link
Member

rom1504 commented Jun 28, 2017

Maybe MediumView should become just View, and elements could connect to that view and specify a medium independently ?

<camomile-player [...] src="medium" sync-all="someView"></camomile-player>

It can make sense to sync on different views, but I'm not sure if it makes sense for an element to have for sources actual different mediums.

edit: "view" would then just be a pubsub

@hbredin
Copy link
Member Author

hbredin commented Jun 28, 2017

I like your proposal very much.

edit: then we should probably rename "View" to "Sync"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants