Skip to content

Release Review: QoSBooking r2.1 (rc Sync26) - #119

Merged
Masa8106 merged 6 commits into
release-snapshot/r2.1-c60335bfrom
release-review/r2.1-c60335b
Aug 28, 2026
Merged

Masa8106 merged 6 commits into
release-snapshot/r2.1-c60335bfrom
release-review/r2.1-c60335b

Conversation

@camara-release-automation

@camara-release-automation camara-release-automation Bot commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

Release Review: r2.1 rc

This PR finalizes the reviewable release content for the active snapshot.

Edit and review this PR before merging it into the release snapshot. After Codeowner and Release Management approval, merging this PR creates the draft release.

Release contents

API Version Status Comparison target
qos-booking-and-assignment 0.2.0-rc.1 rc 0.1.0
qos-booking 0.2.0-rc.1 rc 0.1.0

Dependencies: Commonalities r4.3, ICM r4.2

Codeowner Actions

Tick each box once done. Ticking the last box — "The release is ready for Release Management review" — starts the Release Management review.

  • Update the CHANGELOG

    What to do:

    • Copy all API-consumer-relevant changes from the provided list into the appropriate Breaking changes / Added / Changed / Fixed / Removed sections for each API. List breaking changes both in Breaking changes and in their normal change category.
    • Do not copy administrative, tooling-only, or internal maintenance changes unless they affect API consumers.
    • For each API, fill the CHANGELOG against the stated comparison target, following the release-type rules at the top of the CHANGELOG.
  • Document deferred validation warnings (and hints)

    What to do:

    • Check the CAMARA Validation comment on this PR for warnings and hints.
    • For each warning you do not fix, document it in an issue: include a copy of the validation summary line(s) and the reason the fix is deferred.
    • Document in the same way any validation hint that is applicable to the API and needs to be fixed later.
    • You may group several findings into one issue or split them across issues — either is fine.
    • List the documenting issue(s) in a comment on this PR.
    • Note: documenting deferred warnings is optional but recommended for alpha pre-releases, and mandatory for rc pre-releases and public releases.
  • The release is ready for Release Management review

    Check that:

    • All mandatory release assets for the declared status(es) are present (see the table below "Required release assets per API status" by expanding the arrow);
    • API documentation and test cases are adequate for the target status.

    Tick this box to confirm readiness and to start the Release Management review.

Release Management Actions

The following actions and checks are done by a Release Management reviewer before approving the PR:

  • Assign the Release Management reviewer(s) as assignee(s) of this PR
  • CHANGELOG follows the release documentation rules
  • Breaking changes are documented and version updates follow SemVer rules
  • Mandatory release assets are present for each API according to its status
  • All remaining validation warnings are documented in issues and the reasons for deferral are defensible
Required release assets per API status
Nr Asset alpha rc initial
public
stable
public
1 Release Plan M M M M
2 API Definition(s) M M M M
3 Commonalities compliance O M M M
4 API Documentation M M M M
5 User Stories O O O M
6 Test Cases (basic) O M M M
7 Test Cases (enhanced) O O O M
8 API Description O O M M

M = Mandatory, O = Optional — Full documentation

Valid next actions for codeowners

  • Merge this PR when all Codeowner Actions and Release Management Actions are complete and the required approvals are present — creates the draft release
  • Use /discard-snapshot <reason> in the Release Issue to discard this snapshot, return to planned, and update content on main

Snapshot: r2.1-c60335b

@camara-validation

camara-validation Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

CAMARA Validation — PASS (with warnings)

0 errors, 1 warnings, 3 hints | Profile: standard

View full results

Warnings MUST be documented in one or more issues before this release — see the Codeowner Actions in the PR description.

Updated changelog to reflect recent changes, including new features, fixes, and breaking changes.
@eric-murray

eric-murray commented Aug 19, 2026 •

Copy link
Copy Markdown

Hi @Masa8106

You should explicitly list the breaking changes in the Breaking changes section of the change log, and not just refer to the PR that introduced the breaking changes.

So for qos-booking, you have at least:

  • Response property status renamed to bookingStatus
  • Status AVAILABLE renamed ACTIVATED
  • Status UNAVAILABLE renamed TERMINATED

Adding new states can also be breaking for clients.

And for qos-booking-and-assignment, at least:

  • Pending bookings are notified using a 202 status code rather than 201
  • Failed bookings are notified only using 4XX errors and not a 201 status code

@eric-murray eric-murray left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review complete and documented in #120

The change log must be updated to list breaking changes before I can approve this PR (see this comment).

Ideally the warning created by the unused example (see #121) would be fixed and a new snapshot created for r2.1, but you can defer this fix to a later release candidate if you prefer.

@Masa8106

Copy link
Copy Markdown
Contributor

Hi @eric-murray, thank you for your review.
I have updated the change log to list the breaking changes. Please find it.
In my understanding, I need to fix the issues raised in #120 before an approval of this PR.

@eric-murray eric-murray left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for release by release management

@eric-murray

Copy link
Copy Markdown

Hi @eric-murray, thank you for your review. I have updated the change log to list the breaking changes. Please find it. In my understanding, I need to fix the issues raised in #120 before an approval of this PR.

Hi @Masa8106

I have approved this release candidate for publication if you would prefer to defer addressing issues raised in #120. So you can publish, or delete the snapshot, fix the issues and then create a new snapshot. Up to you and the other codeowners / maintainers.

@Masa8106 Masa8106 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eric-murray, thank you for your approval. As I mentioned in the meeting today, I prefer to defer addressing issues raised in #120.

@jlurien, would you review this PR? I will be merge this PR once you approve or after next Friday EOB. Thank you.

@jlurien jlurien left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Masa8106

Copy link
Copy Markdown
Contributor

Thank for your review, @jlurien.
Please let me merge this PR.

@Masa8106
Masa8106 merged commit 16dd4d4 into release-snapshot/r2.1-c60335b Aug 28, 2026
3 checks passed
@camara-release-automation
camara-release-automation Bot deleted the release-review/r2.1-c60335b branch August 28, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants