Skip to content

Apply release r2.2 review findings from #83 - #87

Open
albertoramosmonagas wants to merge 7 commits into
mainfrom
r2.2-review-findings/issue-83
Open

albertoramosmonagas wants to merge 7 commits into
mainfrom
r2.2-review-findings/issue-83

Conversation

@albertoramosmonagas

@albertoramosmonagas albertoramosmonagas commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?

Add one of the following kinds:

  • cleanup
  • documentation

What this PR does / why we need it:

Special notes for the review:

  • Remove "IoT deployment planning" use case that was not in the original spec nor requested by the issue
  • Specify polygon constraint as "minimum of 3 and maximum of 15 points" matching the schema and PDD,
  • Remove duplicate GC/MC/NC/ND list and "Callback URL and token" definition across sections,
  • Replace non-ASCII characters (×, —, –) with ASCII equivalents,
  • Rename DataQualityInfo to ResponseQualityInfo, as the response may carry values that are not data per se, such as OPERATION_NOT_COMPLETED,
  • Clarify "not an HTTP error indicator" instead of "not an error indicator", since OPERATION_NOT_COMPLETED is indeed an error, just not an HTTP one

Which issue(s) this PR fixes:

Fixes #84, #85, #86 (from #83 release issue)

Changelog input

 release-note
Restructure API inline documentation (#84), rename local schemas to avoid CAMARA common clashes (#85), and rename ResponseStatus to DataQualityInfo to clarify data quality vs error semantics (#86)

@camara-validation

camara-validation Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

CAMARA Validation — PASS (with warnings)

0 errors, 2 warnings, 1 hints | Profile: standard

View full results

@albertoramosmonagas
albertoramosmonagas marked this pull request as ready for review October 6, 2026 11:22
@albertoramosmonagas

Copy link
Copy Markdown
Contributor Author

Ready for review @eric-murray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API inline documentation can be tightened up

1 participant