Skip to content

fix: address RM review findings for r2.1 rc - #54

Merged
maheshc01 merged 1 commit into
mainfrom
fix/rm-review-fixes
Aug 20, 2026
Merged

maheshc01 merged 1 commit into
mainfrom
fix/rm-review-fixes

Conversation

@maheshc01

Copy link
Copy Markdown
Contributor

Summary

Addresses RM review findings from PR #47 (issues #50, #51, #53).

  • x-correlator: Added missing response header to GET /regions 200 response
  • GET /regions error codes: Removed inapplicable 404, 422, 429 — this endpoint does not identify a device and has no range parameters
  • POST description: Corrected to state that applicationProfileId is required
  • info.description: Fixed 404 NOT_FOUND → 404 IDENTIFIER_NOT_FOUND; removed "Notes for API publishers" paragraph referencing non-existent GENERIC_400_MISSING_PORT; updated edgeCloudZoneStatus description to reflect removal of unknown; documented edgeCloudZones as ranked array
  • EdgeCloudZoneStatus: Removed unknown enum value and default: unknown — providers must always return an explicit status
  • EdgeCloudZone: Made edgeCloudRegion and edgeCloudZoneStatus required fields
  • EdgeCloudRegion: Updated to neutral description
  • edgeCloudZones: Documented as ordered from best to worst suitability
  • Example: Added ranked response example using AWS Wavelength zones on Verizon's network (with valid UUIDs — fixes S-212 from validation)

Closes #50
Closes #51
Closes #53

@camara-validation

Copy link
Copy Markdown

CAMARA Validation — PASS

0 errors, 0 warnings, 0 hints | Profile: standard

View full results

@maheshc01

Copy link
Copy Markdown
Contributor Author

@Kevsy requesting your review and approve so that i can go ahead and create a new snapshot

@Kevsy Kevsy left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all points in #53 appear to have been tackled 👍 (as well as #50 and #51)

@maheshc01

Copy link
Copy Markdown
Contributor Author

thank you Kev!

@maheshc01
maheshc01 merged commit df47291 into main Aug 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation needs improvement Review and fix documented error response codes Missing x-correlator response header

2 participants