Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vite] Infinite hmr updates since Linaria 6.2 #1419

Open
PierreGUI opened this issue Jul 31, 2024 · 0 comments
Open

[Vite] Infinite hmr updates since Linaria 6.2 #1419

PierreGUI opened this issue Jul 31, 2024 · 0 comments
Labels
bug report 🦗 Issue is probably a bug, but it needs to be checked cat: performance 🚀 Issue is related to performance needs: complete repro 🖥️ Issue need to have complete repro provided

Comments

@PierreGUI
Copy link

PierreGUI commented Jul 31, 2024

Environment

  • Linaria version: 6.2.1
  • wyw-in-js version: 0.5.4
  • Bundler (+ version): Vite 5.3.2
  • Node.js version: 18.17.1
  • OS: MacOS 14.4.1

WYW config: useWeakRefInEval: false

Description

I can build my Remix project with Vite in Linaria 6.1.0, but this behaviour appeared since version 6.2.0.

When building my entire codebase, build never ends and keeps updating forever:

11:26:09 [vite] hmr update /src/components/clients/navigate/ResponsiveBar.view.wyw-in-js.css
11:26:09 [vite] hmr update /src/components/clients/navigate/ResponsiveMenu.view.wyw-in-js.css
11:26:10 [vite] hmr update /src/components/clients/navigate/Presenter.view.wyw-in-js.css
...
11:27:00 [vite] hmr update /src/components/clients/navigate/Presenter.view.wyw-in-js.css (x371)
11:27:00 [vite] hmr update /src/components/clients/navigate/ResponsiveBar.view.wyw-in-js.css
...
11:29:49 [vite] hmr update /src/components/clients/navigate/Presenter.view.wyw-in-js.css (x738)

With a stripped down version of my app, I am able to build but still see a lot a repeated updates:

11:10:20 [vite] hmr update /src/components/clients/navigate/ResponsiveMenu.view.wyw-in-js.css
...16 times...
11:10:31 [vite] hmr update /src/components/clients/navigate/ResponsiveMenu.view.wyw-in-js.css (x2)
...
11:10:31 [vite] hmr update /src/components/clients/navigate/ResponsiveMenu.view.wyw-in-js.css (x7)
11:10:31 [vite] hmr update /src/components/clients/navigate/ResponsiveMenu.view.wyw-in-js.css
11:10:31 [vite] hmr update /src/components/clients/navigate/ResponsiveMenu.view.wyw-in-js.css (x2)
...
11:10:33 [vite] hmr update /src/components/clients/navigate/ResponsiveMenu.view.wyw-in-js.css (x21)

Reproducible Demo

I don't have that right now. Seems related to some sort of circular dependencies.

@PierreGUI PierreGUI added bug report 🦗 Issue is probably a bug, but it needs to be checked needs: complete repro 🖥️ Issue need to have complete repro provided needs: triage 🏷 Issue needs to be checked and prioritized labels Jul 31, 2024
@github-actions github-actions bot added cat: performance 🚀 Issue is related to performance and removed needs: triage 🏷 Issue needs to be checked and prioritized labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report 🦗 Issue is probably a bug, but it needs to be checked cat: performance 🚀 Issue is related to performance needs: complete repro 🖥️ Issue need to have complete repro provided
Projects
None yet
Development

No branches or pull requests

1 participant