Commit f737dee
committed
test(android): read the install-timeout fixture from the helper manifest fixture
#2618 removed `installArgs` from `AndroidSnapshotHelperManifest` and updated the shared helper
fixture, the packaging script and the parse test, but this file kept its own hand-written manifest
literal with the field still in it, which is what `tsc` rejects on main today's tip: an excess
property on a type that no longer declares it. A second copy of the manifest is also how that field
survived this long.
Both tests re-hash the manifest for the APK they write, so the identity fields carry no test
intent; they now come from `ANDROID_SNAPSHOT_HELPER_FIXTURE_ARTIFACT` like every other helper test.
The one case that still needs a manifest carrying `installArgs` is the parse path that ignores it,
and that case spells the key out inline in `snapshot-helper.test.ts`.1 parent 2cafab3 commit f737dee
1 file changed
Lines changed: 4 additions & 15 deletions
Lines changed: 4 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
31 | 20 | | |
32 | 21 | | |
33 | 22 | | |
| |||
0 commit comments