chore(gates): align layering, mutation, fallow and CI gates with the capture-kit relocation

Moves the executable-policy roots, presentation-owner constant, zone ranks, authority fixture, mutation sharding globs, stryker aliases, fallow baselines and the iOS workflow's android-owned paths-ignore entry onto the new packages/capture-kit paths, and extends the planted-red coverage to the new presentation-owner subpath.

Author: thymikee

.github/workflows/ios.yml

@@ -29,7 +29,7 @@ on:
       - 'packages/*/src/**/*.test.ts'
       - 'packages/*/src/**/__tests__/**/*.ts'
       - 'packages/platform-android/src/**'
-      - 'src/snapshot/snapshot-presentation/android/**'
+      - 'packages/capture-kit/src/snapshot/snapshot-presentation/android/**'
       - 'packages/platform-harmonyos/src/**'
       - 'packages/platform-linux/src/**'
       - 'packages/platform-vega/src/**'

fallow-baselines/health.json

@@ -456,7 +456,7 @@
         "count": 2
       }
     },
-    "src/snapshot/snapshot-lines.ts": {
+    "packages/capture-kit/src/snapshot/snapshot-lines.ts": {
       "crap_moderate": {
         "count": 1
       }
@@ -471,12 +471,12 @@
         "count": 1
       }
     },
-    "src/snapshot/scroll-edge-state.ts": {
+    "packages/capture-kit/src/snapshot/scroll-edge-state.ts": {
       "crap_moderate": {
         "count": 1
       }
     },
-    "src/snapshot/snapshot-presentation/text-surface.ts": {
+    "packages/capture-kit/src/snapshot/snapshot-presentation/text-surface.ts": {
       "crap_high": {
         "count": 1
       }
@@ -550,7 +550,7 @@
     "packages/kernel/src/success-text.ts:high impact",
     "src/cli.ts:complexity",
     "src/commands/interaction/output.ts:high impact",
-    "src/snapshot/snapshot-lines.ts:high impact",
+    "packages/capture-kit/src/snapshot/snapshot-lines.ts:high impact",
     "packages/kernel/src/rect-center.ts:high impact",
     "packages/platform-apple/src/core/app-launch.ts:complexity",
     "packages/kernel/src/record.ts:high impact",
@@ -562,7 +562,7 @@
     "src/client/screenshot-result.ts:high impact",
     "packages/platform-web/src/json-utils.ts:high impact",
     "packages/platform-android/src/settings.ts:complexity",
-    "src/snapshot/snapshot-presentation/text-surface.ts:high impact",
+    "packages/capture-kit/src/snapshot/snapshot-presentation/text-surface.ts:high impact",
     "src/daemon/handlers/session-test-sharding.ts:high impact",
     "src/daemon/replay/internal/native-command.ts:complexity",
     "packages/platform-apple/src/core/debug-symbols/utils.ts:high impact",

scripts/depgraph/model.test.ts

@@ -46,9 +46,9 @@ function authorityFixture(): Map<string, string> {
       "import { SessionStore } from './session-store.ts';",
     ].join('\n'),
     'src/daemon/type-consumer.ts': "import type { SessionStore } from './session-store.ts';\n",
-    'src/snapshot/policy-consumer.ts': [
-      "import type { SessionState } from '../daemon/session-state.ts';",
-      "import type { SessionRef } from '../daemon/session-state.ts';",
+    'packages/capture-kit/src/snapshot/policy-consumer.ts': [
+      "import type { SessionState } from '../../../../src/daemon/session-state.ts';",
+      "import type { SessionRef } from '../../../../src/daemon/session-state.ts';",
       "import './ordinary-target.ts';",
     ].join('\n'),
     'src/daemon/ordinary-consumer.ts': [
@@ -62,7 +62,7 @@ function authorityFixture(): Map<string, string> {
     'src/daemon/session-script-publication-capability.ts':
       'export function isSessionRecording() {}\n',
     'src/daemon/session-state-store.ts': 'export const SessionState = 1;\n',
-    'src/snapshot/ordinary-target.ts': 'export const ordinary = 1;\n',
+    'packages/capture-kit/src/snapshot/ordinary-target.ts': 'export const ordinary = 1;\n',
     'packages/contracts/src/facades/client.ts': 'export type ClientShape = string;\n',
     'packages/contracts/src/facades/capture.ts': 'export type CaptureShape = string;\n',
     'packages/contracts/src/facades/replay.ts': 'export type ReplayShape = string;\n',
@@ -108,7 +108,11 @@ test('authority overlay uses declared roots and symbols, keeps kind separate, an
     labels: ['live-state-authority'],
   });
   assert.deepEqual(
-    graphEdge(graph, 'src/snapshot/policy-consumer.ts', 'src/snapshot/ordinary-target.ts'),
+    graphEdge(
+      graph,
+      'packages/capture-kit/src/snapshot/policy-consumer.ts',
+      'packages/capture-kit/src/snapshot/ordinary-target.ts',
+    ),
     { kind: 'value', labels: ['executable-policy'] },
   );
   assert.deepEqual(
@@ -122,12 +126,16 @@ test('authority overlay uses declared roots and symbols, keeps kind separate, an
 
   const stateEdges = resolveImportEdges(files, authorityWorkspaceTargets()).filter(
     (edge) =>
-      edge.file === 'src/snapshot/policy-consumer.ts' &&
+      edge.file === 'packages/capture-kit/src/snapshot/policy-consumer.ts' &&
       edge.target === 'src/daemon/session-state.ts',
   );
   assert.equal(stateEdges.length, 2, 'the fixture must exercise raw same-pair imports');
   assert.deepEqual(
-    graphEdge(graph, 'src/snapshot/policy-consumer.ts', 'src/daemon/session-state.ts'),
+    graphEdge(
+      graph,
+      'packages/capture-kit/src/snapshot/policy-consumer.ts',
+      'src/daemon/session-state.ts',
+    ),
     {
       kind: 'type',
       labels: ['live-state-shape', 'executable-policy'],

scripts/layering/architecture-ownership.ts

@@ -235,7 +235,7 @@ export const ARCHITECTURE_OWNERSHIP = {
     {
       name: 'snapshot-policy',
       kind: 'executable-policy',
-      roots: ['src/snapshot/'],
+      roots: ['packages/capture-kit/src/snapshot/'],
       forbiddenTargetRoots: ['src/daemon/'],
     },
   ],

scripts/layering/contracts-implementation-policy.ts

@@ -56,7 +56,7 @@ export function contractsImplementationAuthorityViolations(
         violation(
           file.path,
           1,
-          'contracts may not own snapshot quality warning rendering; that presentation policy belongs in src/snapshot/snapshot-presentation',
+          'contracts may not own snapshot quality warning rendering; that presentation policy belongs in packages/capture-kit/src/snapshot/snapshot-presentation',
         ),
       );
     }

scripts/layering/model.test.ts

@@ -253,7 +253,7 @@ test('classifyZone separates the ranked spine from intentionally-unranked zones'
   // Every satellite zone joined the spine; only the composition root stays out, because R2
   // forbids daemon/ from importing commands/ so the files that wire them cannot be ranked.
   assert.equal(classifyZone('mcp'), 'ranked');
-  assert.equal(classifyZone('snapshot'), 'ranked');
+  assert.equal(classifyZone('screenshot-diff'), 'ranked');
   // A zone that is neither ranked nor listed peripheral must be flagged, never
   // silently treated as back-edge-free.
   assert.equal(classifyZone('not-a-real-zone'), 'unclassified');

scripts/layering/model.ts

@@ -41,13 +41,11 @@ const TARGET_DAG_RANK = new Map([
   ['command-registry', 1],
   ['contracts', 1],
   ['maestro', 1],
-  ['recording', 1],
   ['replay-test', 1],
   ['request', 1],
   ['screenshot-diff', 1],
   ['selectors', 1],
   ['session-journal', 1],
-  ['snapshot', 1],
   ['core', 2],
   ['cli-schema', 3],
   ['commands', 3],

scripts/layering/package-boundaries.test.ts

@@ -392,11 +392,13 @@ test('the real tree parses, declares, and passes R11', () => {
   );
   assert.deepEqual([...captureKitPackage.exportTargets.keys()].sort(), [
     '@agent-device/capture-kit',
+    '@agent-device/capture-kit/android-replacement-surface-occlusion',
     '@agent-device/capture-kit/durable-capture',
     '@agent-device/capture-kit/durable-json',
     '@agent-device/capture-kit/ios-snapshot-acquisition',
     '@agent-device/capture-kit/ios-snapshot-engine',
     '@agent-device/capture-kit/ios-snapshot-planning',
+    '@agent-device/capture-kit/ios-snapshot-runtime',
     '@agent-device/capture-kit/mobile-snapshot-semantics',
     '@agent-device/capture-kit/png',
     '@agent-device/capture-kit/png-crop',
@@ -405,15 +407,36 @@ test('the real tree parses, declares, and passes R11', () => {
     '@agent-device/capture-kit/png-size',
     '@agent-device/capture-kit/png-worker-client',
     '@agent-device/capture-kit/post-gesture-stability',
+    '@agent-device/capture-kit/quality-warnings',
     '@agent-device/capture-kit/react-native-overlay',
+    '@agent-device/capture-kit/recording-output-path',
+    '@agent-device/capture-kit/recording-overlay',
+    '@agent-device/capture-kit/recording-telemetry',
+    '@agent-device/capture-kit/recording-video',
+    '@agent-device/capture-kit/repeated-nav-subtree',
     '@agent-device/capture-kit/screenshot-density',
     '@agent-device/capture-kit/screenshot-diff-pixels',
     '@agent-device/capture-kit/screenshot-overlay',
+    '@agent-device/capture-kit/scroll-edge-state',
+    '@agent-device/capture-kit/snapshot-chrome',
     '@agent-device/capture-kit/snapshot-desktop-projection',
+    '@agent-device/capture-kit/snapshot-desktop-surface',
+    '@agent-device/capture-kit/snapshot-diff',
+    '@agent-device/capture-kit/snapshot-evidence',
+    '@agent-device/capture-kit/snapshot-freshness',
+    '@agent-device/capture-kit/snapshot-label-dedup',
+    '@agent-device/capture-kit/snapshot-lines',
+    '@agent-device/capture-kit/snapshot-node-lookup',
     '@agent-device/capture-kit/snapshot-occlusion',
+    '@agent-device/capture-kit/snapshot-presentation-android-helper',
+    '@agent-device/capture-kit/snapshot-presentation-ios-transitions-fixtures',
     '@agent-device/capture-kit/snapshot-quality-backend-capabilities',
     '@agent-device/capture-kit/snapshot-quality-verdict',
     '@agent-device/capture-kit/snapshot-rect-projection',
+    '@agent-device/capture-kit/snapshot-state',
+    '@agent-device/capture-kit/snapshot-timeout-policy',
+    '@agent-device/capture-kit/snapshot-visibility',
+    '@agent-device/capture-kit/text-surface',
   ]);
 
   const provisionKitPackage = packages.find((pkg) => pkg.name === '@agent-device/provision-kit');

scripts/layering/provider-snapshot-presentation-policy.test.ts

@@ -57,6 +57,26 @@ test('R73 rejects an out-of-adapter provider presentation import', () => {
   );
 });
 
+test('R73 rejects a provider import of the capture-kit presentation runtime subpath', () => {
+  const result = violations(
+    new Map([
+      [
+        providerHelper,
+        `import { presentIosSnapshot } from '@agent-device/capture-kit/ios-snapshot-runtime';\nvoid presentIosSnapshot;\n`,
+      ],
+    ]),
+  );
+  assert.ok(
+    result.some(
+      (entry) =>
+        entry.rule === PROVIDER_SNAPSHOT_PRESENTATION_RULE &&
+        entry.file === providerHelper &&
+        entry.message.includes(IOS_SNAPSHOT_PRESENTATION_OWNER),
+    ),
+    JSON.stringify(result),
+  );
+});
+
 for (const planted of [
   {
     name: 'a planted provider residue discard',

scripts/layering/provider-snapshot-presentation-policy.ts

@@ -1,15 +1,15 @@
 // Catches: a provider-* package acquiring an iOS snapshot outside the capture-kit acquisition
-//   entrypoint, or presenting it outside src/snapshot/ios-snapshot-runtime.ts — the exact split
-//   R72's engine convergence closed for the runner layer, mirrored here one layer up for the
-//   provider packages that call into it.
+//   entrypoint, or presenting it outside packages/capture-kit/src/snapshot/ios-snapshot-runtime.ts
+//   — the exact split R72's engine convergence closed for the runner layer, mirrored here one
+//   layer up for the provider packages that call into it.
 // Evidence: 7ee1a5ded7 (#2233) carried provider acquisitions through this one presentation
 //   owner, the change this policy was written to hold in place.
 // Cost: 195 LOC (111 rule + 84 test).
 // Kill criterion: none enforced today; retire only by maintainer decision that provider-* packages
 //   reaching presentation only through @agent-device/capture-kit/ios-snapshot-acquisition, and
 //   never constructing, discarding, or reassigning acquisition residue, no longer matter. An
 //   exports map cannot replace it: it restricts external specifiers, not the transitive walk
-//   into src/snapshot/ or a provider-local `residue` property or assignment.
+//   into packages/capture-kit/src/snapshot/ or a provider-local `residue` property or assignment.
 
 import { parseSync } from 'oxc-parser';
 import type { LayeringViolation, ResolvedImportEdge } from './model.ts';
@@ -18,7 +18,8 @@ import { memberPath, propertyName, visitAst } from './layering-ast.ts';
 export const PROVIDER_SNAPSHOT_PRESENTATION_RULE = 'R73 provider-snapshot-presentation-ownership';
 export const IOS_SNAPSHOT_ACQUISITION_ENTRYPOINT =
   '@agent-device/capture-kit/ios-snapshot-acquisition';
-export const IOS_SNAPSHOT_PRESENTATION_OWNER = 'src/snapshot/ios-snapshot-runtime.ts';
+export const IOS_SNAPSHOT_PRESENTATION_OWNER =
+  'packages/capture-kit/src/snapshot/ios-snapshot-runtime.ts';
 
 const PROVIDER_SOURCE = /^packages\/provider-[^/]+\/src\//;
 const IOS_SNAPSHOT_CAPTURE_KIT_ROOT = 'packages/capture-kit/src/ios-snapshot-';
@@ -109,7 +110,7 @@ function residueViolations(providerFile: string, source: string): LayeringViolat
 function isPresentationTarget(target: string): boolean {
   return (
     target === IOS_SNAPSHOT_PRESENTATION_OWNER ||
-    target.startsWith('src/snapshot/') ||
+    target.startsWith('packages/capture-kit/src/snapshot/') ||
     (target.startsWith(IOS_SNAPSHOT_CAPTURE_KIT_ROOT) &&
       target !== 'packages/capture-kit/src/ios-snapshot-acquisition.ts')
   );