refactor(runtime): own provider-device admission behind a typed capability (#2556)

Ten daemon files imported isActiveProviderDevice from src/provider-device-runtime.ts,
so the daemon read provider runtime ownership mechanics directly from twelve sites
(ten daemon, one daemon runtime composition, one src/core).

The daemon now consumes a named capability: src/daemon/provider-device-admission.ts
declares ProviderDeviceAdmission with the one fact the daemon decides on, defaults to
the no-provider state every un-composed process already sees, and is installed by root
composition where the provider request providers are already composed. The ten leaf
call sites change only their import specifier; the predicate keeps its name, its
per-call read, and the request-scoped ALS behaviour underneath it.

src/core/interactors.ts keeps its edge: it also needs getProviderDeviceInteractor and
sits below the daemon, so it cannot consume the daemon's seam.

Part of #2541

Author: thymikee

src/daemon/__tests__/provider-device-admission.test.ts

@@ -0,0 +1,40 @@
+import { afterEach, beforeEach, expect, test } from 'vitest';
+import type { DeviceInfo } from '@agent-device/kernel/device';
+import {
+  installProviderDeviceAdmission,
+  isActiveProviderDevice,
+  providerDeviceAdmission,
+} from '../provider-device-admission.ts';
+
+const providerDevice = { id: 'provider-1', name: 'Cloud iPhone' } as unknown as DeviceInfo;
+const localDevice = { id: 'local-1', name: 'iPhone 16' } as unknown as DeviceInfo;
+
+let previous = providerDeviceAdmission();
+
+beforeEach(() => {
+  previous = providerDeviceAdmission();
+});
+
+afterEach(() => {
+  installProviderDeviceAdmission(previous);
+});
+
+test('an un-composed process treats every device as local', () => {
+  installProviderDeviceAdmission({ isActive: () => false });
+  expect(isActiveProviderDevice(providerDevice)).toBe(false);
+  expect(isActiveProviderDevice(localDevice)).toBe(false);
+});
+
+test('the installed admission is what the daemon decides on', () => {
+  installProviderDeviceAdmission({ isActive: (device) => device.id === 'provider-1' });
+  expect(isActiveProviderDevice(providerDevice)).toBe(true);
+  expect(isActiveProviderDevice(localDevice)).toBe(false);
+});
+
+test('the fact is read per call, so a request-scoped scope stays live', () => {
+  let owned = false;
+  installProviderDeviceAdmission({ isActive: () => owned });
+  expect(isActiveProviderDevice(providerDevice)).toBe(false);
+  owned = true;
+  expect(isActiveProviderDevice(providerDevice)).toBe(true);
+});

src/daemon/__tests__/request-router-android-modal.test.ts

@@ -16,7 +16,15 @@ import {
 import type { SessionState } from '../session-state.ts';
 import { LeaseRegistry } from '../lease-registry.ts';
 import { makeSessionStore } from '../../__tests__/test-utils/store-factory.ts';
-import { createProviderDeviceRuntimeRequestProviders } from '../../provider-device-runtime.ts';
+import {
+  createProviderDeviceRuntimeRequestProviders,
+  isActiveProviderDevice,
+} from '../../provider-device-runtime.ts';
+import { installProviderDeviceAdmission } from '../provider-device-admission.ts';
+
+// Root composition installs the daemon's provider-device admission; this test composes the
+// request providers the same way, so it installs the fact the same way.
+installProviderDeviceAdmission({ isActive: isActiveProviderDevice });
 import type { ProviderDeviceRuntime } from '@agent-device/contracts/device';
 import { makeTestScreenRecordingResource } from '../../__tests__/test-utils/screen-recording-live-handle.ts';
 import { androidObservation } from '../../platform-runtime.ts';

src/daemon/__tests__/selector-capture-fixture.ts

@@ -12,7 +12,7 @@ import {
   snapshotRuntimeOperationFacts,
 } from '@agent-device/contracts/snapshot-runtime';
 import { deviceShape, type DeviceInfo } from '@agent-device/kernel/device';
-import { isActiveProviderDevice } from '../../provider-device-runtime.ts';
+import { isActiveProviderDevice } from '../provider-device-admission.ts';
 import type { BindDeviceRuntime, InspectDeviceRuntimeFacts } from '../request-runtime-binding.ts';
 import { unavailableDeviceRuntimeGateway } from './test-device-runtime-gateway.ts';
 

src/daemon/__tests__/session-device-resolution.test.ts

@@ -8,7 +8,7 @@ import {
 } from '../session-device-resolution.ts';
 import { appleSessionObservation } from '../../platform-runtime-apple-resources.ts';
 import { resolveTargetDevice } from '@agent-device/device-selection/dispatch-resolve';
-import { isActiveProviderDevice } from '../../provider-device-runtime.ts';
+import { isActiveProviderDevice } from '../provider-device-admission.ts';
 import { ensureDeviceReady } from '../device-ready.ts';
 
 vi.mock('../../platform-runtime-apple-resources.ts', async (importOriginal) => ({
@@ -18,7 +18,7 @@ vi.mock('../../platform-runtime-apple-resources.ts', async (importOriginal) => (
 vi.mock('@agent-device/device-selection/dispatch-resolve', () => ({
   resolveTargetDevice: vi.fn(),
 }));
-vi.mock('../../provider-device-runtime.ts', () => ({
+vi.mock('../provider-device-admission.ts', () => ({
   isActiveProviderDevice: vi.fn(() => false),
 }));
 vi.mock('../device-ready.ts', () => ({

src/daemon/__tests__/snapshot-runtime-fixture.ts

@@ -33,7 +33,7 @@ import {
 import { applePlugin } from '@agent-device/platform-apple';
 import { type DispatchContext } from '../../core/dispatch-context.ts';
 import { getRequestSignal } from '@agent-device/host-kit/request';
-import { isActiveProviderDevice } from '../../provider-device-runtime.ts';
+import { isActiveProviderDevice } from '../provider-device-admission.ts';
 import type { BindDeviceRuntime, InspectDeviceRuntimeFacts } from '../request-runtime-binding.ts';
 import { unavailableDeviceRuntimeGateway } from './test-device-runtime-gateway.ts';
 import { writeSolidPng } from './screenshot-runtime-fixture.ts';

src/daemon/android-foreground-surface.ts

@@ -1,6 +1,6 @@
 import type { AndroidObservationAdapter } from '@agent-device/contracts/android-observation';
 import { AppError } from '@agent-device/kernel/errors';
-import { isActiveProviderDevice } from '../provider-device-runtime.ts';
+import { isActiveProviderDevice } from './provider-device-admission.ts';
 import type { SessionState } from './session-state.ts';
 
 export type AndroidEscapeSurface = {

src/daemon/android-system-dialog.ts

@@ -10,7 +10,7 @@ import { centerOfRect, type SnapshotNode } from '@agent-device/kernel/snapshot';
 import { isSnapshotNodeInteractionBlocked } from '@agent-device/capture-kit/snapshot-occlusion';
 import { expireRefFrame } from './ref-frame.ts';
 import type { SessionState } from './session-state.ts';
-import { isActiveProviderDevice } from '../provider-device-runtime.ts';
+import { isActiveProviderDevice } from './provider-device-admission.ts';
 
 const ANDROID_BLOCKING_MODAL_PATTERN = /\bis(?:n(?:'|'|')?t| not)\s+responding\b/i;
 const ANDROID_CLOSE_APP_PATTERN = /^close app$/i;

src/daemon/device-ready.ts

@@ -1,6 +1,6 @@
 import type { DeviceInfo } from '@agent-device/kernel/device';
 import { ensureLocalPlatformDeviceReady } from '../platform-runtime-device-ready.ts';
-import { isActiveProviderDevice } from '../provider-device-runtime.ts';
+import { isActiveProviderDevice } from './provider-device-admission.ts';
 import { createTtlMemo } from '@agent-device/kernel/ttl-memo';
 
 // Exported so unit tests can assert TTL behavior without duplicating the value.

src/daemon/direct-ios-selector.ts

@@ -1,6 +1,6 @@
 import { isIosFamily } from '@agent-device/kernel/device';
 import type { SnapshotNode } from '@agent-device/kernel/snapshot';
-import { isActiveProviderDevice } from '../provider-device-runtime.ts';
+import { isActiveProviderDevice } from './provider-device-admission.ts';
 import { isPostGestureStabilizationPending } from './deferred-interaction-outcome.ts';
 import type { SessionState } from './session-state.ts';
 import { readSimpleSelectorTarget } from '@agent-device/selectors';

src/daemon/handlers/__tests__/session-doctor-warmup.test.ts

@@ -1,6 +1,6 @@
 import { beforeEach, expect, test, vi } from 'vitest';
 import type { DeviceInfo } from '@agent-device/kernel/device';
-import { isActiveProviderDevice } from '../../../provider-device-runtime.ts';
+import { isActiveProviderDevice } from '../../provider-device-admission.ts';
 import { handleDoctorCommand } from '../session-doctor.ts';
 import { createHostDiagnostics } from '../../../platform-runtime-host-diagnostics.ts';
 import { makeSessionStore } from '../../../__tests__/test-utils/store-factory.ts';
@@ -28,7 +28,7 @@ vi.mock('../session-doctor-app.ts', () => ({
 vi.mock('../session-doctor-metro.ts', () => ({
   probeMetro: vi.fn(async () => ({ id: 'metro', status: 'pass', summary: 'mocked' })),
 }));
-vi.mock('../../../provider-device-runtime.ts', () => ({
+vi.mock('../../provider-device-admission.ts', () => ({
   isActiveProviderDevice: vi.fn(() => false),
 }));