test: simplify selector replay regression

Author: thymikee

src/daemon/handlers/__tests__/session-replay-selector-routes.test.ts

@@ -0,0 +1,68 @@
+import path from 'node:path';
+import { beforeEach, expect, test, vi } from 'vitest';
+
+import { makeIosSession } from '../../../__tests__/test-utils/session-factories.ts';
+import { mkdtempForTestSync } from '../../../__tests__/test-utils/tmp-dir.ts';
+import { dispatchCommand } from '../../../core/dispatch.ts';
+import { SessionStore } from '../../session-store.ts';
+import { runReplayScriptFile } from '../session-replay-runtime.ts';
+import { baseReplayRequest, writeReplayFile } from './session-replay-runtime.fixtures.ts';
+
+vi.mock('../../../core/dispatch.ts', async (importOriginal) => {
+  const actual = await importOriginal<typeof import('../../../core/dispatch.ts')>();
+  return { ...actual, dispatchCommand: vi.fn(), resolveTargetDevice: vi.fn() };
+});
+
+const mockDispatchCommand = vi.mocked(dispatchCommand);
+
+beforeEach(() => {
+  mockDispatchCommand.mockReset();
+  mockDispatchCommand.mockRejectedValue(new Error('no device runner available'));
+});
+
+test('replay executes selector reads before reporting a covered-target divergence', async () => {
+  const root = mkdtempForTestSync('agent-device-replay-selector-routes-');
+  const sessionName = 'default';
+  const sessionStore = new SessionStore(path.join(root, 'sessions'));
+  sessionStore.set(sessionName, makeIosSession(sessionName));
+  const filePath = writeReplayFile(root, [
+    'open "Demo"',
+    'get text "id=\\"field-name\\""',
+    'get attrs "id=\\"field-name\\""',
+    'is visible "id=\\"field-name\\""',
+    'find id "field-name" get attrs',
+    'click "id=\\"field-name\\""',
+  ]);
+  const invoked: string[] = [];
+
+  const response = await runReplayScriptFile({
+    req: baseReplayRequest({ positionals: [filePath] }),
+    sessionName,
+    logPath: path.join(root, 'daemon.log'),
+    sessionStore,
+    invoke: async (request) => {
+      invoked.push(request.command);
+      if (request.command !== 'click') return { ok: true, data: {} };
+      return {
+        ok: false,
+        error: {
+          code: 'COMMAND_FAILED',
+          message: 'Target is covered by another visible element',
+        },
+      };
+    },
+  });
+
+  expect(invoked).toEqual(['open', 'get', 'get', 'is', 'find', 'click']);
+  expect(response.ok).toBe(false);
+  if (response.ok) return;
+  expect(response.error.code).toBe('REPLAY_DIVERGENCE');
+  expect(response.error.details?.divergence).toMatchObject({
+    kind: 'action-failure',
+    step: { index: 6 },
+    cause: {
+      code: 'COMMAND_FAILED',
+      message: 'Target is covered by another visible element',
+    },
+  });
+});

test/integration/android-emulator-e2e/live-replay-scenarios.ts

@@ -15,7 +15,6 @@ import {
   replayAttemptTimeoutMs,
 } from '../live-device-e2e/replay-evidence.ts';
 import { runLiveReplayTestSuite } from '../live-device-e2e/replay-suite.ts';
-import { assertSelectorRouteReplay } from '../live-device-e2e/selector-route-replay.ts';
 
 const C = PUBLIC_COMMANDS;
 
@@ -98,39 +97,4 @@ export async function assertFixtureReplays(context: LiveContext): Promise<void>
     'helper-backed-gesture-recovery',
     'gesture fixture observed two-pointer pan, fling, pinch, rotate, and transform outcomes',
   );
-
-  await assertSelectorRouteReplay(
-    context,
-    path.resolve(
-      'test/integration/replays/android/fixture/02-selector-routes-covered-diagnosis.ad',
-    ),
-    runStep,
-    {
-      postReplayCleanup: [
-        {
-          step: 'open Android cleanup session after focused selector-route replay',
-          args: [
-            'open',
-            'settings',
-            '--platform',
-            'android',
-            '--serial',
-            context.serial,
-            '--session',
-            `${context.session}-cleanup`,
-            '--no-test-ime',
-            '--json',
-          ],
-        },
-        {
-          step: 'restore portrait after focused selector-route replay',
-          args: ['orientation', 'portrait', '--session', `${context.session}-cleanup`, '--json'],
-        },
-        {
-          step: 'close Android cleanup session after focused selector-route replay',
-          args: ['close', '--session', `${context.session}-cleanup`, '--json'],
-        },
-      ],
-    },
-  );
 }

test/integration/ios-simulator-e2e/live-replay-scenarios.ts

@@ -15,7 +15,6 @@ import {
   replayAttemptTimeoutMs,
 } from '../live-device-e2e/replay-evidence.ts';
 import { runLiveReplayTestSuite } from '../live-device-e2e/replay-suite.ts';
-import { assertSelectorRouteReplay } from '../live-device-e2e/selector-route-replay.ts';
 
 const C = PUBLIC_COMMANDS;
 
@@ -76,41 +75,4 @@ export async function assertFixtureReplays(context: LiveContext): Promise<void>
     'gesture fixture counters prove pan/fling/pinch/rotate/transform',
   );
   verifyCommand(context, C.test, 'fixture scripts pass as a suite and emit non-empty JUnit');
-
-  await assertSelectorRouteReplay(
-    context,
-    path.resolve('test/integration/replays/ios/fixture/03-selector-routes-covered-diagnosis.ad'),
-    runStep,
-    {
-      postReplayCleanup: [
-        {
-          step: 'open iOS cleanup session after focused selector-route replay',
-          args: [
-            'open',
-            context.appId,
-            '--platform',
-            'ios',
-            '--udid',
-            context.udid,
-            '--session',
-            `${context.session}-cleanup`,
-            '--state-dir',
-            context.stateDir,
-            '--json',
-          ],
-        },
-        {
-          step: 'close iOS cleanup session after focused selector-route replay',
-          args: [
-            'close',
-            '--session',
-            `${context.session}-cleanup`,
-            '--state-dir',
-            context.stateDir,
-            '--json',
-          ],
-        },
-      ],
-    },
-  );
 }