test(apple-runner): move journaled runner-code classification to the recovery test

The two new cases landed in runner-command-retry.test.ts, which was already over
the 1,000-line test-file tripwire, so the size ratchet refused its growth. They
assert runnerStatusFailureError's reading of the lifecycle journal, so their home
is runner-command-recovery.test.ts, which mirrors that module and drives recovery
through the real stack against a scripted fake runner.

Author: thymikee

packages/platform-apple/src/runner/__tests__/runner-command-recovery.test.ts

@@ -149,3 +149,58 @@ test('a completed read-only command without a retained response rethrows without
   await assert.rejects(result, (error: unknown) => error === transportError);
   assert.equal(invalidate.mock.calls.length, 0);
 });
+
+/**
+ * #2484 follow-up: the journal's code means exactly what the same code means on a live response.
+ * `RUNNER_BUSY` is diagnostic-only — it stays `COMMAND_FAILED` and survives as
+ * `details.runnerErrorCode` — and the retriability it carries is what a polling `wait` rides out
+ * rather than surrendering its budget to a condition that clears on its own.
+ */
+test('a journaled RUNNER_BUSY is classified exactly like a live one', async () => {
+  const { result, invalidate } = await runRecovery({
+    script: [
+      {
+        kind: 'ok',
+        data: {
+          lifecycleState: 'failed',
+          lifecycleErrorCode: 'RUNNER_BUSY',
+          lifecycleErrorMessage: 'The iOS runner is still finishing a previous command.',
+          lifecycleErrorHint: 'Wait a few seconds and retry.',
+        },
+      },
+    ],
+  });
+
+  await assert.rejects(result, (error: unknown) => {
+    assert.ok(error instanceof AppError);
+    assert.equal(error.code, 'COMMAND_FAILED');
+    assert.equal(error.details?.runnerErrorCode, 'RUNNER_BUSY');
+    assert.equal(error.details?.retriable, true);
+    assert.equal(error.details?.recovery, 'runner_reported_failure');
+    return true;
+  });
+  assert.equal(invalidate.mock.calls.length, 0);
+});
+
+test('a journaled RUNNER_WEDGED keeps its fatal code and stays unretriable', async () => {
+  const { result } = await runRecovery({
+    script: [
+      {
+        kind: 'ok',
+        data: {
+          lifecycleState: 'failed',
+          lifecycleErrorCode: 'RUNNER_WEDGED',
+          lifecycleErrorMessage: 'The iOS runner main thread has been stuck.',
+        },
+      },
+    ],
+  });
+
+  await assert.rejects(result, (error: unknown) => {
+    assert.ok(error instanceof AppError);
+    assert.equal(error.code, 'RUNNER_WEDGED');
+    assert.equal(error.details?.runnerErrorCode, 'RUNNER_WEDGED');
+    assert.equal(error.details?.retriable, undefined);
+    return true;
+  });
+});

packages/platform-apple/src/runner/__tests__/runner-command-retry.test.ts

@@ -795,58 +795,6 @@ test('mutating commands preserve runner failure details from status recovery', a
   });
 });
 
-test('status recovery classifies a journaled RUNNER_BUSY exactly like a live one', async () => {
-  const session = makeRunnerSession({ port: 8100, ready: true });
-
-  mockEnsureRunnerSession.mockResolvedValueOnce(session);
-  mockExecuteRunnerCommandWithSession
-    .mockRejectedValueOnce(new AppError('COMMAND_FAILED', 'fetch failed'))
-    .mockResolvedValueOnce({
-      lifecycleState: 'failed',
-      lifecycleErrorCode: 'RUNNER_BUSY',
-      lifecycleErrorMessage: 'The iOS runner is still finishing a previous command.',
-      lifecycleErrorHint: 'Wait a few seconds and retry.',
-    });
-
-  await assert.rejects(
-    () => runAppleRunnerCommand(IOS_SIMULATOR, { command: 'tap', x: 120, y: 240 }),
-    (error: unknown) => {
-      assert.ok(error instanceof AppError);
-      // Not RUNNER_BUSY on the wire: the code is diagnostic-only, exactly as on the live-response
-      // path, and the retriability it carries is what a polling `wait` rides out (#2484 follow-up).
-      assert.equal(error.code, 'COMMAND_FAILED');
-      assert.equal(error.details?.runnerErrorCode, 'RUNNER_BUSY');
-      assert.equal(error.details?.retriable, true);
-      assert.equal(error.details?.recovery, 'runner_reported_failure');
-      return true;
-    },
-  );
-});
-
-test('status recovery keeps RUNNER_WEDGED fatal and unretriable', async () => {
-  const session = makeRunnerSession({ port: 8100, ready: true });
-
-  mockEnsureRunnerSession.mockResolvedValueOnce(session);
-  mockExecuteRunnerCommandWithSession
-    .mockRejectedValueOnce(new AppError('COMMAND_FAILED', 'fetch failed'))
-    .mockResolvedValueOnce({
-      lifecycleState: 'failed',
-      lifecycleErrorCode: 'RUNNER_WEDGED',
-      lifecycleErrorMessage: 'The iOS runner main thread has been stuck.',
-    });
-
-  await assert.rejects(
-    () => runAppleRunnerCommand(IOS_SIMULATOR, { command: 'tap', x: 120, y: 240 }),
-    (error: unknown) => {
-      assert.ok(error instanceof AppError);
-      assert.equal(error.code, 'RUNNER_WEDGED');
-      assert.equal(error.details?.runnerErrorCode, 'RUNNER_WEDGED');
-      assert.equal(error.details?.retriable, undefined);
-      return true;
-    },
-  );
-});
-
 test('mutating commands use recovery guidance when failed status has no runner hint', async () => {
   const session = makeRunnerSession({ port: 8100, ready: true });