fix(orientation): disclose an unconfirmed rotation instead of asserting it

executeSetOrientation fell back to the requested rotation when the owner reported no resulting orientation, then reported 'Rotated to <request>' as a success claim. Keep the requested rotation for compatibility, but mark the claim unconfirmed and warn.

Author: prateekranka

src/daemon/__tests__/orientation-runtime.test.ts

@@ -142,7 +142,7 @@ test('resolves one admitted binding and reports the owner-observed rotation', as
   });
 });
 
-test('falls back to the requested rotation when the owner reports nothing', async () => {
+test('keeps the requested rotation but discloses that the owner reported nothing', async () => {
   const harness = runtimeHarness();
 
   const resolved = await resolveBoundOrientationRuntime({
@@ -156,7 +156,10 @@ test('falls back to the requested rotation when the owner reports nothing', asyn
   expect(await resolved.execute(orientationExecutionParams(['portrait']))).toEqual({
     action: 'orientation',
     orientation: 'portrait',
-    message: 'Rotated to portrait',
+    confirmed: false,
+    warning:
+      'Requested portrait; the device owner reported no resulting orientation, so the rotation is unconfirmed.',
+    message: 'Rotation requested: portrait (unconfirmed)',
   });
 });
 

src/daemon/orientation-runtime.ts

@@ -63,6 +63,21 @@ async function executeSetOrientation(
   const result = await runtime.operations.setOrientation(
     setOrientationInput(requestedRotation, context),
   );
-  const orientation = result?.orientation ?? requestedRotation;
-  return { action: 'orientation', orientation, ...successText(`Rotated to ${orientation}`) };
+  const reported = result?.orientation;
+  if (reported) {
+    return {
+      action: 'orientation',
+      orientation: reported,
+      ...successText(`Rotated to ${reported}`),
+    };
+  }
+  // An owner that reports no resulting rotation is not evidence the device rotated: keep the
+  // requested rotation for compatibility, but disclose the unconfirmed claim instead of asserting it.
+  return {
+    action: 'orientation',
+    orientation: requestedRotation,
+    confirmed: false,
+    warning: `Requested ${requestedRotation}; the device owner reported no resulting orientation, so the rotation is unconfirmed.`,
+    ...successText(`Rotation requested: ${requestedRotation} (unconfirmed)`),
+  };
 }