Skip to content

Commit 5a0840b

Browse files
committed
test: run process smoke before coverage
1 parent 81efd39 commit 5a0840b

3 files changed

Lines changed: 18 additions & 8 deletions

File tree

scripts/check-affected/checks.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,13 @@ export const CHECK_CATALOG: readonly CheckSpec[] = [
8888
// Needs a `pnpm build` output and the npm registry, both of which local runs already have.
8989
localRunnable: true,
9090
},
91+
{
92+
id: 'integration-node',
93+
label: 'Node integration smoke',
94+
kind: { type: 'script', script: 'test:integration:node' },
95+
ciJobs: ['Integration Tests'],
96+
localRunnable: true,
97+
},
9198
{
9299
id: 'vitest-related',
93100
label: 'Tests related by Vitest module graph',
@@ -116,13 +123,6 @@ export const CHECK_CATALOG: readonly CheckSpec[] = [
116123
ciJobs: ['Integration Tests', 'Coverage'],
117124
localRunnable: true,
118125
},
119-
{
120-
id: 'integration-node',
121-
label: 'Node integration smoke',
122-
kind: { type: 'script', script: 'test:integration:node' },
123-
ciJobs: ['Integration Tests'],
124-
localRunnable: true,
125-
},
126126
{
127127
id: 'integration-progress',
128128
label: 'Integration architecture-progress gate',

scripts/check-affected/model.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,11 @@ export const ALL_CHECKS: readonly CheckId[] = [
5353
'mcp-metadata',
5454
'build',
5555
'package',
56+
'integration-node',
5657
'vitest-related',
5758
'unit',
5859
'coverage',
5960
'provider-integration',
60-
'integration-node',
6161
'integration-progress',
6262
'swift-runner',
6363
'android-helpers',

scripts/check-affected/run.test.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,16 @@ test('runChecks combines related tests with lightweight changed-line coverage',
180180
const code = await runChecks(plan, { scripts: ALL_SCRIPTS }, ARGS, { execute, cwd: '.' });
181181

182182
assert.equal(code, 0);
183+
const integrationNodeIndex = executed.findIndex((command) =>
184+
command.includes('test:integration:node'),
185+
);
186+
const affectedCoverageIndex = executed.findIndex((command) => command.includes('related'));
187+
assert.ok(integrationNodeIndex >= 0);
188+
assert.ok(affectedCoverageIndex >= 0);
189+
assert.ok(
190+
integrationNodeIndex < affectedCoverageIndex,
191+
'real-process Node integration must run before coverage can trigger macOS verification stalls',
192+
);
183193
const related = executed.filter((command) => command.includes('related'));
184194
assert.equal(related.length, 1);
185195
assert.ok(related[0]?.includes('--coverage'));

0 commit comments

Comments
 (0)