chore: consolidate makeSnapshotState into capture-kit, rename fixtures file

An adversarial review of the #2402 fixture-hoisting change found a third
copy of makeSnapshotState in packages/capture-kit/src/snapshot-state.fixtures.ts,
predating PR #2397. Since @agent-device/selectors already depends on
capture-kit, make capture-kit's copy canonical (exported as
./snapshot-state-fixtures) and have the selectors package's fixtures module
re-export it instead of duplicating it a third time.

Also rename packages/selectors/src/test-fixtures.ts to
snapshot-geometry.fixtures.ts (subpath ./snapshot-geometry-fixtures) to match
every other test-fixture module's *.fixtures.ts convention in this repo,
which lets it fall under .fallowrc.json's existing blanket **/*.fixtures.ts
dead-code exemption instead of needing a bespoke per-symbol entry.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01USabYbQjD16A2UkkvMpf5x

Author: claude

.fallowrc.json

@@ -305,16 +305,6 @@
         "createAppLogLiveHandle"
       ]
     },
-    {
-      "comment": "#2402: PROPERTY_RUNS, scrollingContainerTypeArb, distinctRectPairArb, and interactionTouchPointScenarioArb are the canonical snapshot/geometry fast-check fixtures both root and this package's tests build on; every consumer (packages/selectors/src/interaction-targeting.test.ts, interaction-touch-point.test.ts, internal/parse.test.ts, and root's wait-positionals.test.ts, kernel/snapshot-ref-grammar.test.ts, commands/replay/ad-script-round-trip.test.ts) is a test-tree file outside --production analysis. makeSnapshotState from the same module is not listed here — its *.fixtures.ts consumers keep it visible to --production analysis already.",
-      "file": "packages/selectors/src/test-fixtures.ts",
-      "exports": [
-        "PROPERTY_RUNS",
-        "scrollingContainerTypeArb",
-        "distinctRectPairArb",
-        "interactionTouchPointScenarioArb"
-      ]
-    },
     {
       "comment": "Android mechanics facet: the package exports the complete named implementation seam for root/core/SDK consumers and package-owned tests; Fallow's production graph does not follow workspace subpath imports through the package exports map.",
       "file": "packages/platform-android/src/mechanics.ts",

docs/agents/testing.md

@@ -69,9 +69,10 @@ Before creating fixtures, look in `src/__tests__/test-utils/`. Import named buil
 that defines them (`session-factories.ts`, `device-fixtures.ts`, `store-factory.ts`); avoid importing
 unrelated helpers through a barrel. Shared `DeviceInfo`, session, snapshot, store, runtime-fact,
 and mocked-binary values belong in a sibling fixture module, not in repeated test literals.
-`makeSnapshotState`, `PROPERTY_RUNS`, and the interaction touch-point/rect arbitraries live in
-`@agent-device/selectors/test-fixtures` — the canonical location root tests and the selectors
-package both build on — not in `src/__tests__/test-utils/`.
+`PROPERTY_RUNS` and the interaction touch-point/rect arbitraries live in
+`@agent-device/selectors/snapshot-geometry-fixtures` — the canonical location root tests and the
+selectors package both build on — not in `src/__tests__/test-utils/`. `makeSnapshotState` itself
+canonically lives in `@agent-device/capture-kit/snapshot-state-fixtures`, re-exported from there.
 
 Use `mkdtempForTest` or `mkdtempForTestSync`. Global setup redirects `TMPDIR` for the run and
 removes it after every worker exits — skip per-test cleanup. An interrupted run may leave a

packages/capture-kit/package.json

@@ -182,6 +182,10 @@
       "types": "./src/snapshot-state.ts",
       "default": "./src/snapshot-state.ts"
     },
+    "./snapshot-state-fixtures": {
+      "types": "./src/snapshot-state.fixtures.ts",
+      "default": "./src/snapshot-state.fixtures.ts"
+    },
     "./snapshot-timeout-policy": {
       "types": "./src/snapshot/snapshot-timeout-policy.ts",
       "default": "./src/snapshot/snapshot-timeout-policy.ts"

packages/selectors/package.json

@@ -4,7 +4,7 @@
   "private": true,
   "sideEffects": false,
   "type": "module",
-  "description": "Shared selector matching, argument, and replay semantics for agent-device. `.` is string-only; `./ast` is the published parser surface behind `agent-device/selectors`; `./engine` is the resolve/list surface reserved for the selector-pipeline owner (R19); `./parameterized-recorded-fill` parameterizes recorded fill payloads against their selectors; the interaction-resolution subpaths (`./selector-pipeline`, `./interaction-targeting`, `./interaction-touch-point`, `./press-retarget`, `./absence-observation*`, …) host the engine execution surface owned by the pipeline; `./test-fixtures` is the canonical home for snapshot/geometry test fixtures this package and root tests both build on.",
+  "description": "Shared selector matching, argument, and replay semantics for agent-device. `.` is string-only; `./ast` is the published parser surface behind `agent-device/selectors`; `./engine` is the resolve/list surface reserved for the selector-pipeline owner (R19); `./parameterized-recorded-fill` parameterizes recorded fill payloads against their selectors; the interaction-resolution subpaths (`./selector-pipeline`, `./interaction-targeting`, `./interaction-touch-point`, `./press-retarget`, `./absence-observation*`, …) host the engine execution surface owned by the pipeline; `./snapshot-geometry-fixtures` is the canonical home for the geometry/touch-point test fixtures this package and root tests both build on (it re-exports `makeSnapshotState` from `@agent-device/capture-kit/snapshot-state-fixtures`, its own canonical home).",
   "dependencies": {
     "@agent-device/ad-script": "workspace:*",
     "@agent-device/capture-kit": "workspace:*",
@@ -72,9 +72,9 @@
       "types": "./src/selector-pipeline-policy.ts",
       "default": "./src/selector-pipeline-policy.ts"
     },
-    "./test-fixtures": {
-      "types": "./src/test-fixtures.ts",
-      "default": "./src/test-fixtures.ts"
+    "./snapshot-geometry-fixtures": {
+      "types": "./src/snapshot-geometry.fixtures.ts",
+      "default": "./src/snapshot-geometry.fixtures.ts"
     },
     "./touch-semantics": {
       "types": "./src/touch-semantics.ts",

packages/selectors/src/absence-observation.test.ts

@@ -1,6 +1,6 @@
 import assert from 'node:assert/strict';
 import { test } from 'vitest';
-import { makeSnapshotState } from './test-fixtures.ts';
+import { makeSnapshotState } from './snapshot-geometry.fixtures.ts';
 import {
   absenceCaptureOptionMessage,
   absenceCaptureOptionRefusal,

packages/selectors/src/interaction-targeting.test.ts

@@ -6,7 +6,7 @@ import {
   makeSnapshotState,
   PROPERTY_RUNS,
   scrollingContainerTypeArb,
-} from './test-fixtures.ts';
+} from './snapshot-geometry.fixtures.ts';
 import {
   classifyActionableTouchCandidates,
   createActionableTouchResolver,

packages/selectors/src/interaction-touch-point.test.ts

@@ -6,7 +6,7 @@ import {
   interactionTouchPointScenarioArb,
   makeSnapshotState,
   PROPERTY_RUNS,
-} from './test-fixtures.ts';
+} from './snapshot-geometry.fixtures.ts';
 import { resolveInteractionTouchPoint } from './interaction-touch-point.ts';
 
 function containsPoint(rect: Rect, point: Point): boolean {

packages/selectors/src/internal/parse.test.ts

@@ -5,7 +5,7 @@ import {
   formatSelectorChainExpression,
   selectorChainArb,
 } from './__tests__/property-arbitraries.ts';
-import { PROPERTY_RUNS } from '../test-fixtures.ts';
+import { PROPERTY_RUNS } from '../snapshot-geometry.fixtures.ts';
 import { parseSelectorChain } from './parse.ts';
 import type { SelectorTerm } from './parse.ts';
 

packages/selectors/src/selector-pipeline.test.ts

@@ -2,7 +2,7 @@ import assert from 'node:assert/strict';
 import { test } from 'vitest';
 import type { RawSnapshotNode, SnapshotNode } from '@agent-device/kernel/snapshot';
 import { SELECTOR_RESOLUTION_POLICIES } from '@agent-device/selectors';
-import { makeSnapshotState } from './test-fixtures.ts';
+import { makeSnapshotState } from './snapshot-geometry.fixtures.ts';
 import {
   listSelectorPipelineMatches,
   resolveSelectorPipeline,

packages/selectors/src/test-fixtures.ts …ectors/src/snapshot-geometry.fixtures.tspackages/selectors/src/test-fixtures.ts renamed to packages/selectors/src/snapshot-geometry.fixtures.ts packages/selectors/src/test-fixtures.ts renamed to packages/selectors/src/snapshot-geometry.fixtures.ts

@@ -1,12 +1,7 @@
 import fc from 'fast-check';
-import {
-  attachRefs,
-  type Rect,
-  type RawSnapshotNode,
-  type SnapshotNode,
-  type SnapshotState,
-  type SnapshotStateProvenance,
-} from '@agent-device/kernel/snapshot';
+import { attachRefs, type Rect, type SnapshotNode } from '@agent-device/kernel/snapshot';
+
+export { makeSnapshotState } from '@agent-device/capture-kit/snapshot-state-fixtures';
 
 /**
  * Run budget for every property in the unit suite. Properties share the unit
@@ -16,19 +11,6 @@ import {
  */
 export const PROPERTY_RUNS = 100;
 
-export function makeSnapshotState(
-  raw: RawSnapshotNode[],
-  // The provenance pair stays correlated: overrides carry it as one value, never as two
-  // independently typed fields.
-  overrides?: Omit<Partial<SnapshotState>, 'backend' | 'producer'> & SnapshotStateProvenance,
-): SnapshotState {
-  return {
-    nodes: attachRefs(raw),
-    createdAt: Date.now(),
-    ...overrides,
-  };
-}
-
 // ---------------------------------------------------------------------------
 // Rects / viewports
 // ---------------------------------------------------------------------------