fix: harden iOS alert smoke scenario (#1767)

* fix: harden iOS alert smoke scenario

* fix: address iOS alert smoke review feedback

* fix: present fixture alert after React commit

Author: thymikee

examples/test-app/src/screens/AutomationLabScreen.tsx

@@ -84,7 +84,10 @@ export function AutomationLabScreen(props: {
     };
   }, []);
 
-  function showAutomationAlert() {
+  useEffect(() => {
+    if (alertResult !== 'opened') return;
+
+    // The opened canary is committed before this effect; the smoke step separately waits for native presentation.
     Alert.alert('Automation confirmation', 'Choose either result to update the visible canary.', [
       {
         style: 'cancel',
@@ -96,6 +99,10 @@ export function AutomationLabScreen(props: {
         onPress: () => setAlertResult('accepted'),
       },
     ]);
+  }, [alertResult]);
+
+  function showAutomationAlert() {
+    setAlertResult('opened');
   }
 
   async function requestMicrophonePermission() {

test/integration/ios-simulator-e2e/live-automation-scenario.ts

@@ -2,6 +2,8 @@ import assert from 'node:assert/strict';
 import fs from 'node:fs';
 import path from 'node:path';
 
+import { DEFAULT_ALERT_TIMEOUT_MS } from '@agent-device/contracts/interaction';
+
 import { PUBLIC_COMMANDS } from '../../../src/command-catalog.ts';
 import {
   assertElementText,
@@ -13,6 +15,7 @@ import { clearStateLaunchUrlMaestroFlow } from './live-fixtures.ts';
 import { type LiveContext, runStep, verifyBehavior, verifyCommand } from './live-harness.ts';
 
 const C = PUBLIC_COMMANDS;
+const ALERT_WAIT_TIMEOUT = String(DEFAULT_ALERT_TIMEOUT_MS);
 const FIXTURE_HOME_TITLE = 'Agent Device Tester';
 const AUTOMATION_DEEP_LINK =
   'agent-device-test-app:///automation?event=cold.start&payload=%7B%22source%22%3A%22deep-link%22%7D';
@@ -33,6 +36,22 @@ async function observeFixtureHome(context: LiveContext) {
   return snapshot;
 }
 
+async function assertAutomationAlertTriggerVisible(context: LiveContext): Promise<void> {
+  const visible = await runStep(context, 'assert automation-open-alert is visible', [
+    'is',
+    'visible',
+    'id="automation-open-alert"',
+  ]);
+  assert.equal(visible.json?.data?.pass, true, JSON.stringify(visible.json));
+}
+
+async function openNativeAlert(context: LiveContext, step: string): Promise<void> {
+  await assertAutomationAlertTriggerVisible(context);
+  await runStep(context, step, ['click', 'id="automation-open-alert"']);
+  // The canary proves JS ran and the state update is observable; alert wait proves native presentation.
+  await assertWaitText(context, 'Alert result: opened');
+}
+
 export async function assertAutomationInput(context: LiveContext): Promise<void> {
   const opened = await runStep(context, 'cold launch fixture', [
     'open',
@@ -148,15 +167,33 @@ export async function assertAutomationInput(context: LiveContext): Promise<void>
   await assertWaitText(context, 'Long presses: 1');
   verifyCommand(context, C.longPress, '800ms hold increments the long-press counter');
 
-  await runStep(context, 'scroll native alert canary into view', ['scroll', 'down', '1']);
-  await runStep(context, 'open native alert', ['click', 'id="automation-open-alert"']);
-  const alert = await runStep(context, 'wait for native alert', ['alert', 'wait', '5000']);
+  await assertElementTextAfterScrolling(
+    context,
+    'id="automation-open-alert"',
+    'Open automation alert',
+  );
+  await openNativeAlert(context, 'open native alert');
+  const alert = await runStep(context, 'wait for native alert', [
+    'alert',
+    'wait',
+    ALERT_WAIT_TIMEOUT,
+  ]);
   assertJsonContains(alert, 'Automation confirmation', 'alert wait should return fixture alert');
   await runStep(context, 'inspect native alert', ['alert', 'get']);
   await runStep(context, 'dismiss native alert', ['alert', 'dismiss']);
   await assertWaitText(context, 'Alert result: cancelled');
 
-  await runStep(context, 'reopen native alert', ['click', 'id="automation-open-alert"']);
+  await openNativeAlert(context, 'reopen native alert');
+  const reopenedAlert = await runStep(context, 'wait for reopened native alert', [
+    'alert',
+    'wait',
+    ALERT_WAIT_TIMEOUT,
+  ]);
+  assertJsonContains(
+    reopenedAlert,
+    'Automation confirmation',
+    'alert wait should return the reopened fixture alert',
+  );
   await runStep(context, 'accept native alert', ['alert', 'accept']);
   await assertWaitText(context, 'Alert result: accepted');
   verifyCommand(context, C.alert, 'alert wait/get/dismiss/accept produce both fixture outcomes');