Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mute button #54

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix mute button #54

wants to merge 5 commits into from

Conversation

jishnu7
Copy link
Contributor

@jishnu7 jishnu7 commented Jun 2, 2021

Clubhouse api doesn't send unmute field for the active user. So we should keep our own flag to store the status.

Fixes #48

@stultus
Copy link
Contributor

stultus commented Jun 2, 2021

I can confirm that the state of the mute button is consistent now. But the mute status shown on the icon of the user is inconsistent.
It goes back to mute state if we refresh the room. see the below screenshot. you can see that even when the user is in unmute, it is shown as mute on the profile icon.
image

@jishnu7
Copy link
Contributor Author

jishnu7 commented Jun 3, 2021

@stultus That should be fixed now. Let me know if it works.

@callmearta
Copy link
Owner

I should check this one. I'll test it when i have the time and if it worked i'll merge it. Thank you for your PR

@stultus
Copy link
Contributor

stultus commented Jun 16, 2021

@callmearta were you able to test this?

@borhanak
Copy link

borhanak commented Jul 2, 2021

The code is not verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mute/Unmute icon state is not consistant
4 participants