Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressing for builds #27

Open
chabad360 opened this issue Nov 19, 2019 · 4 comments
Open

Compressing for builds #27

chabad360 opened this issue Nov 19, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@chabad360
Copy link
Contributor

Is it possible to make this work for a build action? As I would find this very useful for things like static page blogs (that get built on GitHub Actions), where having compressed images is a plus, but not always is simple to compress images prior to committing, and this would be able to solve that issue...

@benschwarz
Copy link
Member

@chabad360 Thanks for getting in touch on this. Sounds like something we'd like to enable.

Could you describe how you'd see this working differently to now? We're using image-actions for our own website, and it's working out really well for us.

@chabad360
Copy link
Contributor Author

chabad360 commented Nov 19, 2019

Thanks for the quick reply!

I am the maintainer of chabad360/hugo-gh-actions and I have a small blog as well. Due to the simple fact that I'm the sole contributor to this blog, I don't see the need for using PR's to add content which would be a blocker for using this action.
What I would want, would be to have this optimize the images on build, so I don't need to go through a few hoops to optimize my images (I don't always work from my main computer, so I use either forestry or Gitpod to add/edit content).

@chabad360
Copy link
Contributor Author

This will be resolved by merging #30.

@benschwarz benschwarz added the enhancement New feature or request label Dec 3, 2019
@JamieCrisman
Copy link

Hopping in to say I'd love this feature as well for basically the same reason. I notice there's a pending PR, but it doesn't seem to add any documentation that would show an example of how to configure it in a push case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
3 participants