only show featured slider on first page

Author: LordSimal

config/.env.ddev

@@ -36,5 +36,5 @@ export DATABASE_URL="mysql://db:db@db:3306/db"
 # Uncomment these to define logging configuration via environment variables.
 #export LOG_DEBUG_URL="file:///path/to/logs/?levels[]=notice&levels[]=info&levels[]=debug&file=debug"
 #export LOG_ERROR_URL="file:///path/to/logs/?levels[]=warning&levels[]=error&levels[]=critical&levels[]=alert&levels[]=emergency&file=error"
-export APP_FULL_BASE_URL="https://plugins.cakephp.org.ddev.site"
 export DEBUG_KIT_SAFE_TLD="site"
+export APP_FULL_BASE_URL="https://plugins.cakephp.org.ddev.site"

resources/css/style.css

@@ -60,4 +60,14 @@
     .featured-packages-slider-button::after {
         content: none;
     }
+
+    .packages-section-divider {
+        @apply flex items-center gap-4 text-xs font-semibold uppercase tracking-[0.24em] text-slate-400;
+    }
+
+    .packages-section-divider::before,
+    .packages-section-divider::after {
+        content: "";
+        @apply h-px flex-1 bg-slate-200;
+    }
 }

src/Controller/PackagesController.php

@@ -29,13 +29,25 @@ public function index()
             ));
         }
 
-        $featuredPackageNames = array_values(array_filter((array)Configure::read('Packages.featured', [])));
-        if ($featuredPackageNames !== []) {
-            shuffle($featuredPackageNames);
-        }
         $featuredPackages = [];
+        $activeFilterKeys = ['search', 'cakephp_slugs', 'php_slugs'];
+        $hasActiveFilters = false;
+        foreach ($activeFilterKeys as $key) {
+            if ($this->hasActiveFilterValue($queryParams[$key] ?? null)) {
+                $hasActiveFilters = true;
+                break;
+            }
+        }
+        $currentPage = max(1, (int)($queryParams['page'] ?? 1));
+        $showFeaturedPackages = !$hasActiveFilters && $currentPage === 1;
+        $featuredPackageNames = [];
+
+        if ($showFeaturedPackages) {
+            $featuredPackageNames = array_values(array_filter((array)Configure::read('Packages.featured', [])));
+            if ($featuredPackageNames !== []) {
+                shuffle($featuredPackageNames);
+            }
 
-        if ($featuredPackageNames !== []) {
             $featuredPackages = $this->Packages
                 ->find()
                 ->contain(['Tags' => function (SelectQuery $q) {
@@ -75,4 +87,31 @@ public function index()
 
         $this->set(compact('featuredPackages', 'packages', 'cakephpTags', 'phpTags'));
     }
+
+    /**
+     * @param mixed $value
+     * @return bool
+     */
+    protected function hasActiveFilterValue(mixed $value): bool
+    {
+        if (is_array($value)) {
+            foreach ($value as $item) {
+                if ($this->hasActiveFilterValue($item)) {
+                    return true;
+                }
+            }
+
+            return false;
+        }
+
+        if ($value === null) {
+            return false;
+        }
+
+        if (is_string($value)) {
+            return trim($value) !== '';
+        }
+
+        return (bool)$value;
+    }
 }

templates/Packages/index.php

@@ -72,6 +72,10 @@
                     </div>
                 </div>
             </section>
+
+            <div class="packages-section-divider mb-8" aria-hidden="true">
+                <span><?= __('All packages') ?></span>
+            </div>
         <?php endif; ?>
 
         <div class="grid gap-6 md:grid-cols-2 xl:grid-cols-3">

tests/TestCase/Controller/PackagesControllerTest.php

@@ -3,6 +3,7 @@
 
 namespace App\Test\TestCase\Controller;
 
+use Cake\Core\Configure;
 use Cake\TestSuite\IntegrationTestTrait;
 use Cake\TestSuite\TestCase;
 
@@ -25,57 +26,47 @@ class PackagesControllerTest extends TestCase
     ];
 
     /**
-     * Test index method
-     *
      * @return void
-     * @link \App\Controller\PackagesController::index()
      */
-    public function testIndex(): void
+    protected function setUp(): void
     {
-        $this->markTestIncomplete('Not implemented yet.');
+        parent::setUp();
+        Configure::write('Packages.featured', ['markstory/asset_compress']);
     }
 
     /**
-     * Test view method
-     *
      * @return void
-     * @link \App\Controller\PackagesController::view()
      */
-    public function testView(): void
+    public function testIndexShowsFeaturedSliderOnFirstPageWithoutFilters(): void
     {
-        $this->markTestIncomplete('Not implemented yet.');
-    }
+        $this->get('/?sort=downloads&direction=desc');
 
-    /**
-     * Test add method
-     *
-     * @return void
-     * @link \App\Controller\PackagesController::add()
-     */
-    public function testAdd(): void
-    {
-        $this->markTestIncomplete('Not implemented yet.');
+        $this->assertResponseOk();
+        $this->assertResponseContains('Featured');
+        $this->assertResponseContains('data-featured-packages-slider');
     }
 
     /**
-     * Test edit method
-     *
      * @return void
-     * @link \App\Controller\PackagesController::edit()
      */
-    public function testEdit(): void
+    public function testIndexHidesFeaturedSliderOnSubsequentPages(): void
     {
-        $this->markTestIncomplete('Not implemented yet.');
+        $this->get('/?sort=downloads&direction=desc&page=2');
+
+        $this->assertResponseOk();
+        $this->assertResponseNotContains('data-featured-packages-slider');
+        $this->assertResponseNotContains('Previous featured package');
     }
 
     /**
-     * Test delete method
-     *
      * @return void
-     * @link \App\Controller\PackagesController::delete()
      */
-    public function testDelete(): void
+    public function testIndexHidesFeaturedSliderWhenSearching(): void
     {
-        $this->markTestIncomplete('Not implemented yet.');
+        $this->get('/?sort=downloads&direction=desc&search=package-02');
+
+        $this->assertResponseOk();
+        $this->assertResponseNotContains('data-featured-packages-slider');
+        $this->assertResponseContains('vendor/package-02');
     }
 }